Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python LSF driver #6960

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Add Python LSF driver #6960

merged 1 commit into from
Feb 13, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 18, 2024

Issue
Resolves #6949

Approach
Do the same as in #6887

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland self-assigned this Jan 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (55a5e12) 85.95% compared to head (1d527d9) 85.90%.

Files Patch % Lines
src/ert/scheduler/lsf_driver.py 81.73% 19 Missing ⚠️
src/ert/scheduler/__init__.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6960      +/-   ##
==========================================
- Coverage   85.95%   85.90%   -0.05%     
==========================================
  Files         379      380       +1     
  Lines       22570    22678     +108     
  Branches      948      946       -2     
==========================================
+ Hits        19400    19482      +82     
- Misses       3058     3077      +19     
- Partials      112      119       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland changed the title Add Python LSF driver Add minimal Python LSF driver Jan 18, 2024
@berland berland added release-notes:new-feature Automatically categorise as new feature in release notes release-notes:skip If there should be no mention of this in release notes and removed release-notes:skip If there should be no mention of this in release notes labels Jan 18, 2024
@berland berland changed the title Add minimal Python LSF driver Add Python LSF driver Jan 20, 2024
@berland berland force-pushed the lsf_driver branch 5 times, most recently from 0124580 to c171a3c Compare February 12, 2024 14:42
@berland berland marked this pull request as ready for review February 12, 2024 14:43
Copy link
Contributor

@pinkwah pinkwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurra!

@berland
Copy link
Contributor Author

berland commented Feb 13, 2024

Tested with actual LSF cluster 🟢

@berland berland enabled auto-merge (rebase) February 13, 2024 11:38
@berland berland merged commit bf8912a into equinor:main Feb 13, 2024
51 checks passed
@berland berland deleted the lsf_driver branch May 29, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:new-feature Automatically categorise as new feature in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create LSF Driver for the Scheduler
3 participants