Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scheduler unit test for propagation of dispatch information to jobs file #6807

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Add scheduler unit test for propagation of dispatch information to jobs file #6807

merged 1 commit into from
Dec 20, 2023

Conversation

jonathan-eq
Copy link
Contributor

Issue
Resolves #6796

@jonathan-eq jonathan-eq self-assigned this Dec 14, 2023
@jonathan-eq jonathan-eq force-pushed the scheduler-unit-test branch 2 times, most recently from 8b81239 to 60c08c2 Compare December 14, 2023 12:32
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af717e2) 83.87% compared to head (47988bf) 83.88%.
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6807      +/-   ##
==========================================
+ Coverage   83.87%   83.88%   +0.01%     
==========================================
  Files         365      365              
  Lines       21398    21444      +46     
  Branches      948      948              
==========================================
+ Hits        17947    17988      +41     
- Misses       3157     3162       +5     
  Partials      294      294

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathan-eq
Copy link
Contributor Author

It is always macos py3.10 causing problems..

@jonathan-eq jonathan-eq force-pushed the scheduler-unit-test branch 2 times, most recently from 489bb50 to 174a9c8 Compare December 15, 2023 12:29
xjules
xjules reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jonathan-eq ! Just had a small comment.

@jonathan-eq jonathan-eq force-pushed the scheduler-unit-test branch 3 times, most recently from 356491b to 7acd8c8 Compare December 19, 2023 10:46
@jonathan-eq jonathan-eq added release-notes:skip If there should be no mention of this in release notes and removed testing labels Dec 20, 2023
berland
berland approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go

@jonathan-eq jonathan-eq merged commit 87da99a into equinor:main Dec 20, 2023
46 checks passed
@jonathan-eq jonathan-eq deleted the scheduler-unit-test branch December 20, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xjules xjules xjules left review comments

@berland berland berland approved these changes

Assignees

@jonathan-eq jonathan-eq

Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test propagation of dispatch information to jobs file
4 participants
@jonathan-eq @codecov-commenter @berland @xjules