Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Create a new contact form for Equinor pension #2550

Merged
merged 17 commits into from
Nov 5, 2024
Merged

✨ Create a new contact form for Equinor pension #2550

merged 17 commits into from
Nov 5, 2024

Conversation

VarunVAshrit
Copy link
Collaborator

No description provided.

@VarunVAshrit VarunVAshrit requested a review from a team as a code owner October 7, 2024 06:30
padms
padms requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@padms padms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor clean up to be done. Otherwise looks good to me.

web/pages/api/forms/service-now-pension.ts Outdated Show resolved Hide resolved
@padms padms self-requested a review October 14, 2024 13:59
padms
padms requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@padms padms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something missing with the styles, the space around the form fields do not resemble the other forms

@BorghildSelle
Copy link
Contributor

This form will need to be updated to look similar with the other forms as in the #2510,
so will try to get the other PR into main so this branch can merge in main and be updated

@VarunVAshrit VarunVAshrit requested a review from padms October 23, 2024 19:37
padms
padms approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@padms padms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VarunVAshrit VarunVAshrit merged commit f4e55c8 into main Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padms padms padms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VarunVAshrit @BorghildSelle @padms