-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Upgrade newsroom #2433 #2448
Merged
Merged
✨ Upgrade newsroom #2433 #2448
Changes from 10 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
dce7a69
:art: start fetching on selection
BorghildSelle 6a11ba1
✨ Index news hero image #2433
padms 744c2de
:art: updated newsroom
BorghildSelle 2aaf981
:art: lint errors and algolia for newsroom
BorghildSelle ae26104
:art: transient props
BorghildSelle 7e72cc5
:Art new player
BorghildSelle 218ed5e
:art: add pagination and translations,degrade next and next sanity
BorghildSelle 78f24fc
Merge branch 'main' into bose/2433
BorghildSelle e7ea199
:art: delete new provider since downgrade
BorghildSelle 2130ba6
:art: responsive versions
BorghildSelle f945746
:art: look over packages
BorghildSelle 021e0d1
:art: adjustments to max w
BorghildSelle 562ad57
Merge branch 'main' into bose/2433
BorghildSelle a1c5a24
:bug: fix lg padding
BorghildSelle 058afa4
Merge branch 'main' into bose/2433
BorghildSelle cf9ad02
:art: update
BorghildSelle 395737b
:art: design changes and added radix ui accordion
BorghildSelle 7d724bb
:art: add max w
BorghildSelle f640539
:art: update
BorghildSelle 5e35ed2
:art: more accessibility
BorghildSelle 9cd0ea2
:art: wrong hook
BorghildSelle 9ecd26b
:art: make algolia search box to core comp
BorghildSelle ef86f5a
:art: fix thumbnail images
BorghildSelle 655b286
:art: specify no end border
BorghildSelle d978d9d
:bug: fix console logs and revert sanity client
BorghildSelle 44839d2
Merge branch 'main' into bose/2433
BorghildSelle 035990f
:bug: fix responsive bugs
BorghildSelle c3d7037
:art: allow a bit bigger images
BorghildSelle 212ac18
:art: change initial load and refinements to sanity
BorghildSelle 7ee8c08
:art: sanity pagination
BorghildSelle f6d7988
:art: update queries
BorghildSelle 32596d5
:art: update groqs
BorghildSelle 3f358ac
:art: take some algolia back
BorghildSelle f1375c6
:art: revert to algolia
BorghildSelle 65df0a7
:art: add skeleton to newsroom
BorghildSelle 804a464
remove failing deprecated tests
BorghildSelle a053eca
:art: remove unused
BorghildSelle f2540f9
Merge branch 'main' into bose/2433
BorghildSelle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
export type ImageWithAlt = { | ||
_type: 'imageWithAlt' | ||
alt: string | ||
isDecorative?: boolean | ||
asset: { | ||
_ref: string | ||
_type: 'reference' | ||
} | ||
crop?: { | ||
_type: 'sanity.imageCrop' | ||
bottom: number | ||
left: number | ||
right: number | ||
top: number | ||
} | ||
hotspot?: { | ||
_type: 'sanity.imageHotspot' | ||
height: number | ||
width: number | ||
x: number | ||
y: number | ||
} | ||
} | ||
|
||
export type ImageWithAltAndCaption = { | ||
_type: 'imageWithAltAndCaption' | ||
attribution?: string | ||
caption?: string | ||
image: ImageWithAlt | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be here?