Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put required * for label into form #2505

Closed
BorghildSelle opened this issue Sep 3, 2024 · 5 comments
Closed

Put required * for label into form #2505

BorghildSelle opened this issue Sep 3, 2024 · 5 comments
Assignees

Comments

@BorghildSelle
Copy link
Contributor

BorghildSelle commented Sep 3, 2024

The * in label for required field should not be in default value for sanity as this can be overwritten and ignored.
Should be added after in the form component

@BorghildSelle BorghildSelle self-assigned this Sep 3, 2024
@BorghildSelle BorghildSelle changed the title But required * for label into form Put required * for label into form Sep 3, 2024
@BorghildSelle
Copy link
Contributor Author

@meols
Acceptance criteria is that:

  • the form still works, hehe
  • shows the All fields are required text at the top
  • shows the * for required fields
  • gives error if you try to submit without filling out required fields
  • gives error if you have filled all fields but not completed the human robot check
  • gives good information with the new meta text below the label of fields (for instance in the test/career-contact form with country/city)

@meols
Copy link
Collaborator

meols commented Oct 21, 2024

@BorghildSelle - some comments, without having tested all forms

  • we would prefer to have the * and text below the form as described in #2334 - and also where can we edit the text (we have just received a request for some edits)
  • Couldn't the added meta texts be "leading text/ledetekst" as we have done it for the existing fields. Looks strange with some texts within and some outside of the fields (and I prefer within)
  • Where do we edit the Tick the box if you would like to send....
  • Currently users just click submit, and doesn't do anything with Captcha - should that be needed?

@BorghildSelle
Copy link
Contributor Author

BorghildSelle commented Oct 21, 2024

@meols

  • about the *: from uutilsynet.no :
    "Det er også mulig å bruke et symbol for å merke obligatoriske felter. For at bruk av symbol skal være godkjent merking, må meningen med symbolet forklares før det tas i bruk første gang i skjemaet. Det kan for eksempel være en tekst som sier «Obligatoriske felter er merket med * » eller lignende, over første skjemafelt."
    About the text "All fields with * are mandatory" can be edited in Text snippets > Form
  • The text within a textfield is a placeholder and will disappear when you start to write, and if the information is important then it should not be as placeholder. If you have started writing and forgot the format that was in the placeholder, you have to empty the textfield to get back the information. So for input formats its recommended to show the information after one starts to type as well.
  • Tick the box if you would like to send.... -> Text Snippets > Supporting Documents checkbox
  • The Captcha solution is the same as before, the only difference now is that the submit button is not default disabled until captcha and required fields are filled out. It will instead give validation messages if they are not done, if one clicks submit before captcha and required fields are filled out.

@meols
Copy link
Collaborator

meols commented Oct 24, 2024

Thanks @BorghildSelle

  • Okay with moving the text above the form - could it be in small text?
  • We are fine with following standards/recommendations, but shouldn't all input text fields be handled the same way?
  • For the Supporting documents checkbox, is there a reason why the text snippet for the Careers contact form is located within the Career fair form/folder? Shouldn't it be in the Careers contact folder? We have tried to update text for the Careers contact form tick box (and added/removed a dot and published several times), but it still shows the same text as for the Career fair, which is wrong.
  • image.png
  • Thanks for explaining the minor Captcha change, which is fine of course

@BorghildSelle
Copy link
Contributor Author

BorghildSelle commented Oct 28, 2024

@meols
Have made the text small now,
Also there was textsnippet that was in wrong group.
Have moved careers_contact_form_supporting_documents to group careerContactForm now.
In the forms they were both using the career fair textsnippet, and should now use the correct one.

On its way to staging

BorghildSelle added a commit that referenced this issue Nov 4, 2024
* 🎨 more accessibility

* 🎨 add tel type

* 🎨 remove logs

* 🎨 update documentation with eds feature request link

* 🎨 fix typo

* 🎨update to small text and remove placeholders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants