-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade newsroom #2433
Comments
@BorghildSelle @meols The latest version is looking great. No major comments. |
Suggest the below image to be coded in for News articles that are missing images. If its possible to pull from a few options (for variations) let me know and I can upload more. But one is fine too :) |
@NickHaggerty1 Will do! |
@meols @NickHaggerty1 The newsroom is updated now and can be tested.
|
@BorghildSelle @meols Hey, tested on the above and looks good to me. Little repetitive with the images when filtering to older news items but dont think we need to worry about this too much. |
@BorghildSelle - looks good with regards to the test cases listed - but I don't see the image update on the top news. Even tried to republish it again today. Also I don't see the two latest articles I published today, neither on the new/English newsroom or the old/Norwegian news room. Only one of the articles is visible in the three articles at the bottom of each article. Also I created a new tag (Test) and used it as a topic tag, but it isn't added to the topic filters. |
@meols The news articles not getting updated is expected as I have paused indexing for dev environment. |
@padms @BorghildSelle - the newsroom looks good and updated - but when I click to filter on the new Test tag i created I got this result (both in Chrome and Edge) |
Assuming we will have the new newsroom in Norwegian as well, even if it isn't "activated" on dev/stage? |
@meols I will look into these :) |
* 🎨 start fetching on selection * ✨ Index news hero image #2433 * 🎨 updated newsroom * 🎨 lint errors and algolia for newsroom * 🎨 transient props * :Art new player * 🎨 add pagination and translations,degrade next and next sanity * 🎨 delete new provider since downgrade * 🎨 responsive versions * 🎨 look over packages * 🎨 adjustments to max w * 🐛 fix lg padding * 🎨 update * 🎨 design changes and added radix ui accordion * 🎨 add max w * 🎨 update * 🎨 more accessibility * 🎨 wrong hook * 🎨 make algolia search box to core comp * 🎨 fix thumbnail images * 🎨 specify no end border * 🐛 fix console logs and revert sanity client * 🐛 fix responsive bugs * 🎨 allow a bit bigger images * 🎨 change initial load and refinements to sanity * 🎨 sanity pagination * 🎨 update queries * 🎨 update groqs * 🎨 take some algolia back * 🎨 revert to algolia * 🎨 add skeleton to newsroom * 🎨 remove unused --------- Co-authored-by: Padmaja <[email protected]>
No description provided.
The text was updated successfully, but these errors were encountered: