Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade newsroom #2433

Closed
BorghildSelle opened this issue Aug 2, 2024 · 13 comments
Closed

Upgrade newsroom #2433

BorghildSelle opened this issue Aug 2, 2024 · 13 comments
Assignees

Comments

@BorghildSelle
Copy link
Contributor

No description provided.

@BorghildSelle BorghildSelle self-assigned this Aug 2, 2024
padms added a commit that referenced this issue Aug 8, 2024
@NickHaggerty1
Copy link

@BorghildSelle @meols The latest version is looking great. No major comments.
One small thing on the filters, we talked about a CLEAR ALL option if a user has gone crazy with the filter options.
Otherwise good from the design side.

@NickHaggerty1
Copy link

NickHaggerty1 commented Aug 23, 2024

Suggest the below image to be coded in for News articles that are missing images. If its possible to pull from a few options (for variations) let me know and I can upload more. But one is fine too :)

@NickHaggerty1
Copy link

35a7f87d47454941b3706b9c59545e8e.jpg

@BorghildSelle
Copy link
Contributor Author

@NickHaggerty1 Will do!

@BorghildSelle
Copy link
Contributor Author

@meols @NickHaggerty1 The newsroom is updated now and can be tested.
Criterias:

  • Possible to filter news on different tags
  • Can remove filters and clear all
  • Can quick search on keyword
  • Looks good in mobile and desktop
  • Can tab through newsroom with access to all interactive elements
  • all news have thumbnail images

@NickHaggerty1
Copy link

@BorghildSelle @meols Hey, tested on the above and looks good to me. Little repetitive with the images when filtering to older news items but dont think we need to worry about this too much.

@meols
Copy link
Collaborator

meols commented Sep 10, 2024

@BorghildSelle - looks good with regards to the test cases listed - but I don't see the image update on the top news. Even tried to republish it again today. Also I don't see the two latest articles I published today, neither on the new/English newsroom or the old/Norwegian news room. Only one of the articles is visible in the three articles at the bottom of each article. Also I created a new tag (Test) and used it as a topic tag, but it isn't added to the topic filters.
(Not sure how/if custom date and tags plays a part in this)
image.png

image.png

@padms
Copy link
Contributor

padms commented Sep 10, 2024

@meols The news articles not getting updated is expected as I have paused indexing for dev environment.

@meols
Copy link
Collaborator

meols commented Sep 12, 2024

@padms @BorghildSelle - the newsroom looks good and updated - but when I click to filter on the new Test tag i created I got this result (both in Chrome and Edge)
image.png

@meols
Copy link
Collaborator

meols commented Sep 12, 2024

I get the more or less the same look when filtering on Ireland as a topic. Is it relevant that both have "No relevant content..." for Country - which probably can happen in "real life use" as well.
image.png

@meols
Copy link
Collaborator

meols commented Sep 12, 2024

Assuming we will have the new newsroom in Norwegian as well, even if it isn't "activated" on dev/stage?

@BorghildSelle
Copy link
Contributor Author

@meols I will look into these :)

@padms
Copy link
Contributor

padms commented Oct 21, 2024

image.png

Only the above archived news links (only in en) work in dev, all others give 404.

BorghildSelle added a commit that referenced this issue Nov 4, 2024
* 🎨 start fetching on selection

* ✨ Index news hero image #2433

* 🎨 updated newsroom

* 🎨 lint errors and algolia for newsroom

* 🎨 transient props

* :Art new player

* 🎨 add pagination and translations,degrade next and next sanity

* 🎨 delete new provider since downgrade

* 🎨 responsive versions

* 🎨 look over packages

* 🎨 adjustments to max w

* 🐛 fix lg padding

* 🎨 update

* 🎨 design changes and added radix ui accordion

* 🎨 add max w

* 🎨 update

* 🎨 more accessibility

* 🎨 wrong hook

* 🎨 make algolia search box to core comp

* 🎨 fix thumbnail images

* 🎨 specify no end border

* 🐛 fix console logs and revert sanity client

* 🐛 fix responsive bugs

* 🎨 allow a bit bigger images

* 🎨 change initial load and refinements to sanity

* 🎨 sanity pagination

* 🎨 update queries

* 🎨 update groqs

* 🎨 take some algolia back

* 🎨 revert to algolia

* 🎨 add skeleton to newsroom

* 🎨 remove unused

---------

Co-authored-by: Padmaja <[email protected]>
@padms padms self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants