Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capital letters on breadcrumbs #2272

Closed
BorghildSelle opened this issue Apr 30, 2024 · 7 comments
Closed

Capital letters on breadcrumbs #2272

BorghildSelle opened this issue Apr 30, 2024 · 7 comments
Assignees
@padms @BorghildSelle

Comments

@BorghildSelle
Copy link
Contributor

No description provided.

@BorghildSelle
Copy link
Contributor Author

@meols Can you verify that the custom breadcrumbs work on dev/staging? Then its ready to go to preprod

@meols
Copy link
Collaborator

meols commented May 2, 2024 •
edited
Loading

@BorghildSelle - looks like the capital letter issue is fixed. We get a capital letter at the start and if we write it. But the other issue we had fixed for breadcrumbs, that we sometimes need to have a hyphen in the breadcrumbs to have correct grammar, is not in place now. See earlier discussion on Slack, with discussion and examples and screenshot below: https://equinor.slack.com/archives/C01MU3H6G0Y/p1683826370196819
image.png
image.png

@BorghildSelle
Copy link
Contributor Author

@meols ah, hm, i took back the old one as it was just made underline on hover. But will look into it

@meols
Copy link
Collaborator

meols commented May 3, 2024

Thanks @BorghildSelle 🙂

@BorghildSelle
Copy link
Contributor Author

@meols Can you check again now?

@meols
Copy link
Collaborator

meols commented May 6, 2024

Thanks @BorghildSelle 👍 - looks great! 👏

BorghildSelle added a commit that referenced this issue May 6, 2024
@BorghildSelle
🎨 take back old breadcrumbs and update styling #2272 (#2273)
368e80f 
* 🎨 take back old breadcrumbs and update styling

* 🎨 update old breadcrumb logic

* 🎨 updates to breadcrumbs

* 🎨 refactor

* 🎨 use variable
@meols
Copy link
Collaborator

meols commented May 8, 2024

Thanks for the link @BorghildSelle - looks great also on preprod 😄 I even found some editorial errors for breadcrumbs to correct when testing 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@padms padms

@BorghildSelle BorghildSelle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@millianapia @padms @meols @BorghildSelle