Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align eventcardcontent #2208

Closed
millianapia opened this issue Mar 21, 2024 · 3 comments
Closed

Align eventcardcontent #2208

millianapia opened this issue Mar 21, 2024 · 3 comments
Assignees
@millianapia
Labels
🐛 bug Something isn't working

Comments

@millianapia
Copy link
Contributor

Screenshot 2024-03-20 at 13.05.36.png
@millianapia millianapia added the 🐛 bug Something isn't working label Mar 21, 2024
@millianapia millianapia self-assigned this Mar 21, 2024
millianapia added a commit that referenced this issue Apr 9, 2024
@millianapia
💄 Change eventcard padding and layout #2208
c217479 
Note, in prod, all three fields are filled, so the gap between the description, place and date and title is not that big as it appears in test
@meols
Copy link
Collaborator

meols commented May 2, 2024

@millianapia - not sure what to test as there is no description/criteria - but assuming you have bottom aligned the horizontal lines, which looks good. But currently in prod we can have three event cards horizontally without activating horizontal scroll, but on dev both two and three cards are now stacked on top of each other.
image.png

image.png

image.png

@millianapia
Copy link
Contributor Author

@meols sorry for not writing up the test case, this was only so the lines were horizontally aligned. Regarding the cards stackinng, i will create a separate issue for this and look into this today

@meols
Copy link
Collaborator

meols commented May 3, 2024

Thanks @millianapia

millianapia added a commit that referenced this issue May 14, 2024
@millianapia
💄 Change eventcard padding and layout #2208 (#2229)
82f96d5 
Note, in prod, all three fields are filled, so the gap between the description, place and date and title is not that big as it appears in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millianapia millianapia

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@millianapia @meols