Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events template - revise spacing between components #2141

Closed
NickHaggerty1 opened this issue Feb 20, 2024 · 3 comments
Closed

Events template - revise spacing between components #2141

NickHaggerty1 opened this issue Feb 20, 2024 · 3 comments
Assignees

Comments

@NickHaggerty1
Copy link

NickHaggerty1 commented Feb 20, 2024

As editors we see the Event template follows spacing as per other templates that allow for background colour. As we dont separate modules by colour background we would like to reduce the space/padding between the separate elements.
Not quite sure what the pixel gaps are between elements and text fields but they should be consistent through the layout:

  1. Space between H2 titles to next element (links or ingress or text for example) should be consistent with other templates.
  2. Space between all modules (eg People and contacts) should be reduced by half - 80 pixels? as suggestion. so all have equal spacing.Screenshot 2024-02-20 at 11.31.05.png
@millianapia millianapia self-assigned this Mar 5, 2024
@meols
Copy link
Collaborator

meols commented Apr 10, 2024

@millianapia - still doesn't look consistent - tested on this page: https://web-global-development-equinor-web-sites-dev.c2.radix.equinor.com/test/mettes-event-test
Let's discuss in the workshop.

@meols
Copy link
Collaborator

meols commented Apr 19, 2024

@millianapia - the colored top banner is now bigger, looks too big to me (unless it is agreed with @NickHaggerty1 ). The ingress at the top looks smaller than the ingress in contacts, header color still looks too black (maybe on another card?), the spacing doesn't look consistent. I have added a green box on screenshots to illustrate the difference in spacing. Please consult Nick/Borghild/Figma for the correct spacing. I'm not all into the details on it.
image.png

image.png

image.png

@millianapia
Copy link
Contributor

@meols a new round of review is needed :) spacing and sizing regarding the h2 and h3 directly in the content should be discussed in a new issue, this is only for spacing within the event template with the spacing between the components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants