Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Teaser link to reuse in text teaser, key numbers components and anywhere else if any. #2066

Closed
padms opened this issue Jan 19, 2024 · 2 comments
Closed

Refactor Teaser link to reuse in text teaser, key numbers components and anywhere else if any. #2066

padms opened this issue Jan 19, 2024 · 2 comments
Assignees
@millianapia
Labels
🚀 ready to deploy Use this if issue is ready to be deployed

Comments

@padms
Copy link
Contributor

padms commented Jan 19, 2024

No description provided.

@padms padms mentioned this issue Jan 19, 2024
Merged
@millianapia millianapia self-assigned this Jan 30, 2024
millianapia added a commit that referenced this issue Jan 31, 2024
@millianapia
♻️ Refactor TextTeaser to use readmorelink #2066
b4a6d4e
millianapia added a commit that referenced this issue Feb 6, 2024
@millianapia
♻️ Refactor 5050hero to use readmorelink #2066
28d8f55
millianapia added a commit that referenced this issue Feb 6, 2024
@millianapia
♻️ Refactor ReadMoreLink to a more general component #2066
4acb67b
millianapia added a commit that referenced this issue Feb 6, 2024
@millianapia
♻️ Add variant on textteaser #2066
f26066d
millianapia added a commit that referenced this issue Feb 12, 2024
@millianapia
♻️ Pick type from linkprops #2066
bf5a6f6
@millianapia
Copy link
Contributor

@NickHaggerty1 @meols test that the links in these components works and looks as before:

  • Teasertext
  • fiftyfiftyhero
  • form
  • call to action

@NickHaggerty1
Copy link

@millianapia Think it looks fine, couple of comments though:
Not sure what you mean by call to action component. Assume text component link?
We also tested on Key numbers component and Link displays as a hyperlink. Should as per all other components (that are not buttons)

millianapia added a commit that referenced this issue Feb 21, 2024
@millianapia
Refactor Teaser link to reuse in text teaser, key numbers components #…
e1f5c92 
…2066 (#2096)

* ♻️ Refactor TextTeaser to use readmorelink #2066

* ♻️ Refactor 5050hero to use readmorelink #2066

* ♻️ Refactor ReadMoreLink to a more general component #2066

* ♻️ Add variant on textteaser #2066

* ♻️ Pick type from linkprops #2066
@millianapia millianapia added the 🚀 ready to deploy Use this if issue is ready to be deployed label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millianapia millianapia

Labels
🚀 ready to deploy Use this if issue is ready to be deployed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@millianapia @padms @BorghildSelle @NickHaggerty1