Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teaser component image is not optmized #1997

Closed
fernandolucchesi opened this issue Nov 24, 2023 · 3 comments
Closed

Teaser component image is not optmized #1997

fernandolucchesi opened this issue Nov 24, 2023 · 3 comments
Assignees
@millianapia
Labels
🚀 ready to deploy Use this if issue is ready to be deployed

Comments

@fernandolucchesi
Copy link
Contributor

fernandolucchesi commented Nov 24, 2023 •
edited
Loading

image
@millianapia millianapia self-assigned this Dec 1, 2023
millianapia added a commit that referenced this issue Dec 5, 2023
@millianapia
💄 add sizes for teaser component #1997
1e907e9
millianapia added a commit that referenced this issue Dec 11, 2023
@millianapia
💄 Add sizes #1997
c284c13
millianapia added a commit that referenced this issue Dec 18, 2023
@millianapia
💄 Small pixel change #1997
517ed0d
@millianapia
Copy link
Contributor

@meols @NickHaggerty1 the test case is to check that the image for the teaser component looks like before, and that the warning in console from the screenshot is removed

@meols
Copy link
Collaborator

meols commented Jan 4, 2024

@millianapia - the teaser image looks good to me, but maybe you could check also @NickHaggerty1? I don't see the warning in console, but struggle to see if I should have made some selections apart from selecting console as there are many other error messages and warnings (?!)

@NickHaggerty1
Copy link

@millianapia same as Mette, so guess approved

@millianapia millianapia added the 🚀 ready to deploy Use this if issue is ready to be deployed label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millianapia millianapia

Labels
🚀 ready to deploy Use this if issue is ready to be deployed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@millianapia @fernandolucchesi @meols @NickHaggerty1