Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Event promotion #1929

Closed
meols opened this issue Oct 9, 2023 · 4 comments
Closed

Issue with Event promotion #1929

meols opened this issue Oct 9, 2023 · 4 comments
Assignees
Labels
🐛 bug Something isn't working 🚀 ready to deploy Use this if issue is ready to be deployed

Comments

@meols
Copy link
Collaborator

meols commented Oct 9, 2023

On the https://www.equinor.com/investors page we see an issue with events promotion, showing the two cards visible for events with different width. Could this be related to using Horisontal scroll? We have the same two promotions visible on this page https://www.equinor.com/investors/events-and-presentations as well, with what looks like the correct width on the cards and horisontal scroll isn't used.
Private Zenhub Image

Private Zenhub Image

We also have events on this page: https://www.equinor.com/news-and-media/events where Current and upcoming events have horisontal scroll on and shows the wrong width - but the past events below also have horisontal scroll on, but shows the correct width.
Private Zenhub Image

@meols meols added the 🐛 bug Something isn't working label Oct 9, 2023
@fernandolucchesi
Copy link
Contributor

seems related to #1928

@padms padms self-assigned this Nov 28, 2023
padms added a commit that referenced this issue Nov 28, 2023
@padms
Copy link
Contributor

padms commented Nov 29, 2023

@meols This is fixed and can be tested on this page

Issue can be replicated only when horizontal scroll is enabled only with 2 upcoming events in event promotion.

@padms
Copy link
Contributor

padms commented Dec 19, 2023

@meols The issue with upcoming events was that " select events from tags" was neither disabled nor enabled. When set to disabled, the upcoming events are shown.

"select events from tags" is selected by default now. So, this isn't an issue anymore.

@meols
Copy link
Collaborator Author

meols commented Jan 22, 2024

Thanks @padms - this is approved 😄

padms added a commit that referenced this issue Jan 22, 2024
@padms padms added the 🚀 ready to deploy Use this if issue is ready to be deployed label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🚀 ready to deploy Use this if issue is ready to be deployed
Projects
None yet
Development

No branches or pull requests

3 participants