Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to Full width image component #1756

Closed
NickHaggerty1 opened this issue Jul 12, 2023 · 10 comments
Closed

Adjustments to Full width image component #1756

NickHaggerty1 opened this issue Jul 12, 2023 · 10 comments
Assignees
Labels
📜 Run migration script This issue requires changes in schema or content which is done through script

Comments

@NickHaggerty1
Copy link

Currently the Full width image component is defined as 10:3. We would like on occasion to use more height so would like to add option on images.

  1. Narrow (10/3) - Current. Default
  2. 2/1 - New option

Would it be possible to display crop as 2/1 on mobile? Currently the wide image looks very narrow on a mobile especially when next to a teaser component

@fernandolucchesi
Copy link
Contributor

@NickHaggerty1 what about tablets (medium sized screens)?

@millianapia millianapia self-assigned this Jul 25, 2023
padms added a commit that referenced this issue Aug 17, 2023
@meols
Copy link
Collaborator

meols commented Aug 29, 2023

@padms - it looks to me as 10:3 needs to be preselected/default, otherwise we will need to edit all full image components and select 10:3 (and the same goes for "Original" aspect ration in the image component)
Private Zenhub Image

@padms
Copy link
Contributor

padms commented Aug 29, 2023

@meols We can run a script to fix this for existing components. For newly created ones, the default option is selected.

@meols
Copy link
Collaborator

meols commented Aug 30, 2023

@padms - when I add a full width image I see nothing selected for aspect ratio and I need to click and make a choice.
Private Zenhub Video

@padms
Copy link
Contributor

padms commented Aug 30, 2023

@meols Ran a script which set aspectRatio of all fullWidthImages to 10:3

@padms
Copy link
Contributor

padms commented Sep 1, 2023

@padms - when I add a full width image I see nothing selected for aspect ratio and I need to click and make a choice.
Uploaded asset

@meols Fixed now!

@meols
Copy link
Collaborator

meols commented Sep 1, 2023

@padms - I still don't see 10:3 default/pre-selected
Private Zenhub Video

@padms
Copy link
Contributor

padms commented Sep 6, 2023

@meols There was an issue with the pipeline, so it didn't get deployed. Now its deployed and fixed.

@meols
Copy link
Collaborator

meols commented Sep 19, 2023

Thanks @padms - this is approved

@padms padms added the 📜 Run migration script This issue requires changes in schema or content which is done through script label Sep 20, 2023
@fernandolucchesi
Copy link
Contributor

Waiting for #1626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 Run migration script This issue requires changes in schema or content which is done through script
Projects
None yet
Development

No branches or pull requests

5 participants