Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crude oil update articles should not appear in "latest news" list on news articles #1293

Closed
SvSven opened this issue Sep 30, 2022 · 4 comments
Assignees
Labels
🐛 bug Something isn't working 🚀 ready to deploy Use this if issue is ready to be deployed

Comments

@SvSven
Copy link
Contributor

SvSven commented Sep 30, 2022

The query here: https://github.com/equinor/energyvision/blob/main/web/lib/queries/news.ts#L93-L102

Should be updated to exclude the crude oil news tag.

@SvSven SvSven added the 🐛 bug Something isn't working label Sep 30, 2022
@fernandolucchesi fernandolucchesi self-assigned this Oct 3, 2022
@SvSven
Copy link
Contributor Author

SvSven commented Oct 3, 2022

It's a bit hard-coded with the tag name like that, but we'd have the same thing if we use the _id 😅

Looks good to me otherwise ✅

@fernandolucchesi
Copy link
Contributor

fernandolucchesi commented Oct 3, 2022

It's a bit hard-coded with the tag name like that, but we'd have the same thing if we use the _id 😅

Looks good to me otherwise ✅

Yes, we can add this logic to the sanity component itself instead of harding coding it. Sounds clever I believe. Component is added automatically to the news template, better to hardcode.

@fernandolucchesi
Copy link
Contributor

@meols, can you please test this on the dev studio?

News tagged with 'crude-oil-assays' will not show up in the component anymore

@meols
Copy link
Collaborator

meols commented Oct 12, 2022

@fernandolucchesi - works at it should now - thanks! 😄

@fernandolucchesi fernandolucchesi added the 🚀 ready to deploy Use this if issue is ready to be deployed label Oct 14, 2022
fernandolucchesi added a commit that referenced this issue Oct 14, 2022
@SvSven SvSven closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🚀 ready to deploy Use this if issue is ready to be deployed
Projects
None yet
Development

No branches or pull requests

3 participants