-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H3 has different sizes in different documents #1140
Comments
@NickHaggerty1 can you assist me on this one? |
Sure @fernandolucchesi I can try. Though this related to the work done by Victor at the start of the year. Im not sure I this was ever merged back to Figma. I would assume the correct H3 size is on the TOPIC / MAGAZINE / HOME templates. So if the news is different to this, then I think you can just change the News template to match, as there shouldnt be a difference. |
Not sure I understand the purpose of the Admittedly I haven't looked at this part of the code in a long time, so is using these components just bringing it in line with the rest? |
@SvSven - we really don't see a difference, but please make news H3 the same as on other pages if you find some differences in the code. @NickHaggerty1 |
Yes, the other components are using it, so this is to make sure that when we update it in one place, it updates all the components. |
@fernandolucchesi Sounds good ✅ |
H3 is different in news articles compared to topic pages
Since they are two different templates, the h3 doesn't have to look the same. On the other hand, the ones for the topic pages was updated a while back and we might have forgot to look into the news article h3. Figma does not have any examples for h3 in the news article as far as I can see. :)
Actions
The text was updated successfully, but these errors were encountered: