Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H3 has different sizes in different documents #1140

Closed
fernandolucchesi opened this issue Jun 9, 2022 · 6 comments
Closed

H3 has different sizes in different documents #1140

fernandolucchesi opened this issue Jun 9, 2022 · 6 comments
Assignees
Labels
🚀 ready to deploy Use this if issue is ready to be deployed 🎨 UX

Comments

@fernandolucchesi
Copy link
Contributor

fernandolucchesi commented Jun 9, 2022

H3 is different in news articles compared to topic pages

Since they are two different templates, the h3 doesn't have to look the same. On the other hand, the ones for the topic pages was updated a while back and we might have forgot to look into the news article h3. Figma does not have any examples for h3 in the news article as far as I can see. :)

Actions

  • Compare the two templates and see if it would make sense to align them
  • Update figma sketches accordingly
@fernandolucchesi
Copy link
Contributor Author

@NickHaggerty1 can you assist me on this one?

@NickHaggerty1
Copy link

Sure @fernandolucchesi I can try. Though this related to the work done by Victor at the start of the year. Im not sure I this was ever merged back to Figma. I would assume the correct H3 size is on the TOPIC / MAGAZINE / HOME templates. So if the news is different to this, then I think you can just change the News template to match, as there shouldnt be a difference.

@SvSven
Copy link
Contributor

SvSven commented Sep 5, 2022

Not sure I understand the purpose of the h2Heading and h3Heading components here - seems to me like the only difference is the size attribute on the main Heading component?

Admittedly I haven't looked at this part of the code in a long time, so is using these components just bringing it in line with the rest?

@meols
Copy link
Collaborator

meols commented Sep 5, 2022

@SvSven - we really don't see a difference, but please make news H3 the same as on other pages if you find some differences in the code. @NickHaggerty1
Topic page:
image.png
News page:
image.png

@fernandolucchesi
Copy link
Contributor Author

Not sure I understand the purpose of the h2Heading and h3Heading components here - seems to me like the only difference is the size attribute on the main Heading component?

Admittedly I haven't looked at this part of the code in a long time, so is using these components just bringing it in line with the rest?

Yes, the other components are using it, so this is to make sure that when we update it in one place, it updates all the components.

@SvSven
Copy link
Contributor

SvSven commented Sep 6, 2022

@fernandolucchesi Sounds good ✅

fernandolucchesi added a commit that referenced this issue Sep 13, 2022
@fernandolucchesi fernandolucchesi added the 🚀 ready to deploy Use this if issue is ready to be deployed label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 ready to deploy Use this if issue is ready to be deployed 🎨 UX
Projects
None yet
Development

No branches or pull requests

5 participants