Skip to content

Commit

Permalink
🚩 remove feature flags for promotions horizontal scroll (#1373)
Browse files Browse the repository at this point in the history
  • Loading branch information
SvSven committed Feb 21, 2023
1 parent 606e9cf commit b89dbfe
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion studio/schemas/objects/promotion/promotion.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export default {
options: { sortable: false },
validation: (Rule: Rule) => Rule.required().min(1).max(1),
},
Flags.IS_DEV && {
{
name: 'useHorizontalScroll',
title: 'Use horizontal scroll',
description:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import styled from 'styled-components'
import type { EventCardData, EventPromotionSettings } from '../../../types/types'
import EventsCard from '../../cards/EventsCard'
import { HorizontalScroll, HorizontalScrollItem } from '../../shared/HorizontalScroll'
import { Flags } from '../../../common/helpers/datasetHelpers'

const PairWrapper = styled.div`
--card-minWidth: 250px;
Expand Down Expand Up @@ -79,7 +78,7 @@ const MultipleEventCards = ({
data = data.slice(0, eventPromotionSettings.pastEventsCount)
}

if (Flags.IS_DEV && renderScroll) {
if (renderScroll) {
return (
<HorizontalScroll type="card">
{data.map((item) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import TopicPageCard from '../../cards/TopicPageCard'
import PeopleCard from '../../cards/PeopleCard/PeopleCard'
import MultipleEventCards from './MultipleEventCards'
import { HorizontalScroll, HorizontalScrollItem } from '../../shared/HorizontalScroll'
import { Flags } from '../../../common/helpers/datasetHelpers'
import useWindowSize from '../../../lib/hooks/useWindowSize'

const CardsWrapper = styled.div`
Expand Down Expand Up @@ -113,7 +112,7 @@ const MultiplePromotions = ({
)
}

if (Flags.IS_DEV && renderScroll) {
if (renderScroll) {
return (
<HorizontalScroll type="card">
{data.map((item) => {
Expand Down

0 comments on commit b89dbfe

Please sign in to comment.