Reorder attribte updates in basicobject.load #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokva
force-pushed
the
reorder-attribute-update
branch
from
d2654b1 to
ef42df3
Compare
There are far more scalar elements than boolean elements, so it makes sense to in the if-else chain check the scalar first. On top of that, raise a ValueError should the value type of the attribute not be one of the three blessed values.
jokva
force-pushed
the
reorder-attribute-update
branch
from
ef42df3 to
56a1ec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are far more scalar elements than boolean elements, so it makes
sense to in the if-else chain check the scalar first.
On top of that, raise a ValueError should the value type of the
attribute not be one of the three blessed values.