Avoid crash on too large padbyte values #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some files have rather non-sensical padbyte field following a segment, with it being as large as the full segment, including the header. When chopping padbytes off actual record information, this needs to be taken into account in order to avoid overflow, or realloc-to-negative.
jokva
force-pushed
the
too-large-padbytes
branch
from
c011c31 to
39deb33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some files have rather non-sensical padbyte field following a segment,
with it being as large as the full segment, including the header. When
chopping padbytes off actual record information, this needs to be taken
into account in order to avoid overflow, or realloc-to-negative.