Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken links #432

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Update broken links #432

merged 3 commits into from
Nov 14, 2023

Conversation

achaikou
Copy link
Contributor

No description provided.

@achaikou achaikou force-pushed the update_broken_links branch from a223c2f to 1845c95 Compare November 14, 2023 11:06
Copy link

@ajaust ajaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. I only added one optional comment.

README.md Outdated Show resolved Hide resolved
@achaikou achaikou force-pushed the update_broken_links branch from 1845c95 to 9defaaf Compare November 14, 2023 11:35
@achaikou achaikou merged commit 9251c8d into equinor:master Nov 14, 2023
21 checks passed
@achaikou
Copy link
Contributor Author

Thanks, @geolr !
RP66v1 specification is available now, so links are updated.

@nicolascordoba1
Copy link

In the documentation there is a citation to Appendix G but I'm not seeing it on the right side menu

@ajaust
Copy link

ajaust commented Nov 28, 2023

I didn't find any part of the documentation where "Appendix G" is mentioned. The only place seems to be a comment in the source code. The source code refers to the Custer Tape Subset which has an Appendix G. If you think that there is something actually wrong with the documentation, please don't hesitate to open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants