Permit reprcode change to the same reprcode #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently a check has been introduced that reported an error in case someone changes default reprcode from the template in the object, but doesn't change the value itself (leaving it to be default). But it hasn't accounted for the case where reprcode wasn't actually changed, but repeated to be the same as in template. We don't want any error in this case. Fixed and added test.
ErlendHaa
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently a check has been introduced that reported an error in case
someone changes default reprcode from the template in the object, but
doesn't change the value itself (leaving it to be default).
But it hasn't accounted for the case where reprcode wasn't actually
changed, but repeated to be the same as in template. We don't want any
error in this case.
Fixed and added test.