Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release [email protected] #913

Merged
merged 3 commits into from
Nov 26, 2020
Merged

Release [email protected] #913

merged 3 commits into from
Nov 26, 2020

Conversation

pomfrida
Copy link
Contributor

@pomfrida pomfrida commented Nov 24, 2020 •
edited
Loading

[0.5.0] - 2020-11-26

Added

Changed

  • Updated line height for Cell Text (Table) tokens and text color for Snackbar #824
  • Changed module types for better support with commonjs and esm. Using the <some-eds-npm-package>/commonjs path on packages should no longer be needed and will be deprecated in the future (#887)

Resolves #908

@pomfrida pomfrida marked this pull request as draft November 24, 2020 16:10
@pomfrida pomfrida changed the title [WIP] Release tokens [WIP] Release [email protected] Nov 24, 2020
@pomfrida pomfrida self-assigned this Nov 24, 2020
@pomfrida pomfrida added npm core-react eds-core-react labels Nov 24, 2020
vnys
vnys requested changes Nov 24, 2020
View reviewed changes
Copy link
Member

@vnys vnys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would change the phrasing a bit

libraries/tokens/CHANGELOG.md Outdated Show resolved Hide resolved
@mimarz
Copy link
Contributor

mimarz commented Nov 25, 2020

The module changes also applies to this package.

  • Changed module types for better support with commonjs and esm. Using the <some-eds-npm-package>/commonjs path on packages should no longer be needed and will be deprecated in the future (Simplify dependencies and package type #868)

@pomfrida pomfrida changed the title [WIP] Release [email protected] Release [email protected] Nov 26, 2020
@pomfrida pomfrida marked this pull request as ready for review November 26, 2020 08:38
@pomfrida pomfrida changed the title Release [email protected] Release [email protected] Nov 26, 2020
wenche
wenche approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@wenche wenche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pomfrida pomfrida requested a review from vnys November 26, 2020 09:11
vnys
vnys approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@vnys vnys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pomfrida pomfrida merged commit 153d014 into develop Nov 26, 2020
@pomfrida pomfrida deleted the ts-tokens-release branch November 26, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnys vnys vnys approved these changes

@wenche wenche wenche approved these changes

@mimarz mimarz Awaiting requested review from mimarz

Assignees

@pomfrida pomfrida

Labels
core-react eds-core-react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create pre-release for tokens
4 participants
@pomfrida @mimarz @wenche @vnys