[WIP]: Scrim types #531
Closed
[WIP]: Scrim types #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Install typescript and types for react and react-dom * Add support for typescript by using .ts extensions for js files * Change file extensions to .ts in figma-broker
* Fix tsconfig for tokens package. Didn't realise that this was missing... * Add typescript and typescript config * Rename index.js -> index.ts * Rename file endings for icons in figma broker
* Add typescript packages * Add tsconfig * Couldn't do it without the tslib deps, even if it's supposed to be a dep on rollup-plugin-typescript2 * Disable ts checks as a baseline before porting
* First try for typescript support for Divider * In the middle of using proptables from ts components in the storybook * Lot's of lot's of tweeks to make prop tables in storybook working. This commit is kind of a proof of concept * Remove classname, key and ref from props table * Removed debug env * Removed configuration of typescript in storybook main * Remove old testing stuffs * Remove old rollup typescript plugin * Delete copy'n pasted babel typescript transpiler, we use rollup plugin instead * Remove testing stuffs
* First try for typescript support for Divider * In the middle of using proptables from ts components in the storybook * Lot's of lot's of tweeks to make prop tables in storybook working. This commit is kind of a proof of concept * Remove classname, key and ref from props table * Removed debug env * Removed configuration of typescript in storybook main * Remove old testing stuffs * Remove old rollup typescript plugin * Delete copy'n pasted babel typescript transpiler, we use rollup plugin instead * Remove testing stuffs * Fix test
* configure eslint for typescript * one config to rule them all * update stuff
|
With this I'm stuck with an empty props in docgen. I don't know why this i happening. From es build file |
|
My impression is that the code and the tests itself have some flaws... I think we are struggling both with TS and suboptimal code here. E.g. Quick fix from mighty Internet to avoid crash in the tests with <Scrim onKeyDown={handleClose}> Also it's hard to wrap my head around the differents between TS KeyboardEvent and React.KeyboardEvent. It's a mess right now :/ |
…d make more sense
as the onClose is either called by react onClick or javascript keydown EventListener we don't need the React.KeyboardEvent
fix: clear up some confusion
|
Closing this pull request since it is far behind the rest of the code base. (Aka long lived PR's are not a good idea :) ) |
|
See PR #654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #249