Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing line-height for ul, li #367

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Add missing line-height for ul, li #367

merged 2 commits into from
Jun 23, 2020

Conversation

wenche
Copy link
Contributor

@wenche wenche commented Jun 15, 2020

Add line-height 24px as of Figma design

@wenche wenche requested review from mimarz and vnys as code owners June 15, 2020 13:21
mimarz
mimarz approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mimarz mimarz mentioned this pull request Jun 16, 2020
Merged
vnys
vnys requested changes Jun 16, 2020
View reviewed changes
libraries/core-react/src/List/List.jsx Outdated Show resolved Hide resolved
@wenche wenche requested a review from vnys June 22, 2020 08:20
vnys
vnys approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@vnys vnys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wenche wenche merged commit 462531c into equinor:develop Jun 23, 2020
@wenche wenche deleted the list-lineheight branch June 23, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnys vnys vnys approved these changes

@mimarz mimarz mimarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenche @mimarz @vnys