fix: when using menu in a form, the form is submitted #3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a menu item if closeOnClcik is set to false
FredrikMWold
requested review from
vnys,
oddvernes and
torleifhalseth
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
Menuin a form, the form is submitted when clicking on a menu item ifcloseMenuOnClcikis set to falseThe problem is a missing
type="button".Looks like this bug has been hiding behind the fact that having it in a form and having
closeMenuOnClickset tofalseis rare.The
onClickcallback being called twice when you setcloseMenuOnClickset tofalseand dont give aonClosecallback seems to have some have resolved for that instance