Allow enabling/disabling multi row selection in eds-data-grid #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhwaage
requested review from
vnys,
oddvernes and
torleifhalseth
as code owners
| @@ -227,6 +228,7 @@ export function EdsDataGrid<T>({ | |||
| debugHeaders: debug, | |||
| debugColumns: debug, | |||
| enableRowSelection: rowSelection ?? false, | |||
| enableMultiRowSelection: multiRowSelection, | |||
There was a problem hiding this comment.
I would recommend using the same property name as the library.
There was a problem hiding this comment.
That's reasonable - I wrote it like this to match the syntax of enableRowSelection
There was a problem hiding this comment.
@torleifhalseth The enable prefix was added to make it clearer what the prop does. I'd argue that prefixing enableMultiRowSelection as well makes sense, given this.
There was a problem hiding this comment.
have we concluded on this? Is there any further work needed or can i merge this?
There was a problem hiding this comment.
Imo we can leave it as is, since it matches the pattern for enableRowselection already in place.
magnh
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwards multiRowSelection options to tanstack, allowing users to enable/disable multi row selection.