Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API Sync by GitHub Action (2024-01-17) #73

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

This API Sync PR was automated through GitHub Actions workflow_displatch
on 2024-01-17.

  • latest Equinix Metal API spec have been fetched
  • patches have been applied
  • generated client has been updated

@ctreatma
Copy link
Contributor

Unfortunately the acceptance tests won't run automatically for these sync job PRs because GitHub Actions does not trigger workflows for PRs that were opened by GitHub Actions.

However, since the sync job PRs are internal, I ran the job manually and it passed; link is also below in the This branch was successfully deployed dialog.

@t0mk when you have a moment please review these changes from the spec update.

@@ -658,7 +655,7 @@ components:
type: string
quantity:
description: The number of servers sent to check capacity.
type: integer
type: string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is an improvement. But probably OK since we don't use capacity query anywhere yet.

@t0mk
Copy link
Contributor

t0mk commented Jan 19, 2024

Otherwise there were some filtering changes and some attributes were made optional.

@t0mk t0mk merged commit 838aaea into main Jan 19, 2024
2 checks passed
@t0mk t0mk deleted the sync/gh-1705515463 branch January 19, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants