Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use openapigen v7.0.0 #47

Merged
merged 2 commits into from
Sep 13, 2023
Merged

feat: use openapigen v7.0.0 #47

merged 2 commits into from
Sep 13, 2023

Conversation

t0mk
Copy link
Contributor

@t0mk t0mk commented Sep 11, 2023

@t0mk t0mk requested a review from ctreatma September 11, 2023 12:12
@t0mk t0mk force-pushed the openapigen_v7.0.0 branch 2 times, most recently from f9e0b84 to 8609295 Compare September 11, 2023 12:34
@ctreatma
Copy link
Contributor

Are there new options we can set for the generator? It looks like there are a lot of potentially unnecessary or undesirable changes here; the docs seem to have been deleted entirely, and a bunch of *_api.py files have either been moved or deleted as well.

@t0mk
Copy link
Contributor Author

t0mk commented Sep 11, 2023

@ctreatma Yes, the module seem to have changed :(. I need to check that python is indeed a sucessor of python-nextgen but if yes, it's not great that the generator changes module structure this much :(.

Docs moved:
https://github.com/equinix-labs/metal-python/blob/openapigen_v7.0.0/equinix_metal/docs/apis/tags/DevicesApi.md

There don't seem to be new params relevant to the changes:
https://openapi-generator.tech/docs/generators/python/
(unless they're uncdocumented)

I make this WIP

@t0mk t0mk changed the title Use openapigen v7.0.0 [WIP] Use openapigen v7.0.0 Sep 11, 2023
@t0mk
Copy link
Contributor Author

t0mk commented Sep 12, 2023

@ctreatma, yesterday I accidentaly generated the code with the old-obsoleted python generator from the v6 openapigen, that's why the structure was so mangled.

The python generator is indeed sucessor of the experimental python-nextgen. I generated code with python generator from v7.0.0 now and the diff is leaner.

You can see Makefile updates in fe07e9b and the generated code update in 0fc266a

Please review

@ctreatma ctreatma changed the title [WIP] Use openapigen v7.0.0 feat: use openapigen v7.0.0 Sep 12, 2023
Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks way better! Thanks!

@t0mk t0mk merged commit f445a4c into main Sep 13, 2023
@t0mk t0mk deleted the openapigen_v7.0.0 branch September 13, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants