Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Kept #76

Merged
merged 1 commit into from
Sep 1, 2023
Merged

[Cleanup] Kept #76

merged 1 commit into from
Sep 1, 2023

Conversation

kbrizzle
Copy link
Contributor

@kbrizzle kbrizzle commented Sep 1, 2023

Followup from: #74.

Adds minor cleanups + virtual on L2 implementation functions to enable proper mixin pattern.

@kbrizzle kbrizzle requested a review from arjun-io September 1, 2023 02:01
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Unit Test Coverage Report

Coverage after merging britz-fix-kept-virtual into v2 will be
99.07%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts/accumulator/types
   Accumulator6.sol100%100%100%100%
   UAccumulator6.sol100%100%100%100%
contracts/attribute
   Factory.sol95.24%75%100%100%24
   Initializable.sol100%100%100%100%
   Instance.sol93.33%83.33%100%100%19
   Ownable.sol93.10%87.50%88.89%100%27
   Pausable.sol96.88%91.67%100%100%29
   ReentrancyGuard.sol90.91%75%100%100%40
contracts/attribute/CrossChainOwnable
   CrossChainOwnable_Arbitrum.sol100%100%100%100%
   CrossChainOwnable_Optimism.sol100%100%100%100%
   CrossChainOwnable.sol90%75%100%100%25
contracts/attribute/CrossChainOwner
   CrossChainOwner_Arbitrum.sol100%100%100%100%
   CrossChainOwner_Optimism.sol100%100%100%100%
   CrossChainOwner.sol91.67%83.33%100%100%14
contracts/attribute/Kept
   Kept_Arbitrum.sol100%100%100%100%
   Kept_Optimism.sol100%100%100%100%
   Kept.sol90%50%85.71%100%26
contracts/attribute/interfaces
   IFactory.sol100%100%100%100%
   IInitializable.sol100%100%100%100%
   IInstance.sol100%100%100%100%
   IKept.sol100%100%100%100%
   IOwnable.sol100%100%100%100%
   IPausable.sol100%100%100%100%
   IReentrancyGuard.sol100%100%100%100%
contracts/mocks
   MockAccumulator6.sol100%100%100%100%
   MockCrossChainOwnable_Arbitrum.sol50%50%50%50%11–12, 7
   MockCrossChainOwnable_Optimism.sol50%50%50%50%11–12, 7
   MockCurveMath18.sol100%100%100%100%
   MockCurveMath6.sol100%100%100%100%
   MockERC20.sol100%100%100%100%
   MockFactory.sol83.33%66.67%100%100%10, 14
   MockFixed18.sol100%100%100%100%
   MockFixed6.sol100%100%100%100%
   MockInitializable.sol96.15%90%100%100%20, 59
   MockInstance.sol91.67%83.33%100%100%13
   MockJumpRateUtilizationCurve18.sol100%100%100%100%
   MockJumpRateUtilizationCurve6.sol100%100%100%100%
   MockKept_Arbitrum.sol88.24%50%100%100%16, 30
   MockKept_Optimism.sol88.24%50%100%100%16, 30
   MockKept.sol88.24%50%100%100%16, 25
   MockNumberMath.sol100%100%100%100%
   MockOwnable.sol83.33%50%100%100%9
   MockPAccumulator6.sol100%100%100%100%
   MockPausable.sol90%75%100%100%9
   MockPController6.sol100%100%100%100%
   MockReentrancyGuard.sol86.67%75%100%100%11, 21
   MockStorage.sol100%100%100%100%
   MockToken18.sol100%100%100%100%
   MockToken6.sol100%100%100%100%
   MockTokenOrEther18.sol100%100%100%100%
   MockUAccumulator6.sol100%100%100%100%
   MockUFixed18.sol100%100%100%100%
   MockUFixed6.sol100%100%100%100%
   MockUJumpRateUtilizationCurve18.sol100%100%100%100%
   MockUJumpRateUtilizationCurve6.sol100%100%100%100%
contracts/number
   NumberMath.sol100%100%100%100%
contracts/number/types
   Fixed18.sol100%100%100%100%
   Fixed6.sol100%100%100%100%
   UFixed18.sol100%100%100%100%
   UFixed6.sol100%100%100%100%
contracts/pid/types
   PAccumulator6.sol100%100%100%100%
   PController6.sol100%100%100%100%
contracts/storage
   Storage.sol100%100%100%100%
contracts/token/types
   Token18.sol100%100%100%100%
   Token6.sol100%100%100%100%
   TokenOrEther18.sol100%100%100%100%
contracts/utilization
   CurveMath18.sol100%100%100%100%
   CurveMath6.sol100%100%100%100%
contracts/utilization/types
   JumpRateUtilizationCurve18.sol83.33%100%50%83.33%56
   JumpRateUtilizationCurve6.sol83.33%100%50%83.33%55
   UJumpRateUtilizationCurve18.sol83.33%100%50%83.33%56
   UJumpRateUtilizationCurve6.sol83.33%100%50%83.33%55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants