[Fix] Send claimed market fees to factory owner #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrizzle
reviewed
Aug 25, 2023
| /// @param receiver The address to receive the fee | ||
| /// @param fee The amount of the fee to claim | ||
| function _claimFee(address receiver, UFixed6 fee) private returns (bool) { | ||
| if (msg.sender != receiver) return false; | ||
| if (msg.sender == address(factory())) receiver = factory().owner(); |
There was a problem hiding this comment.
you should just pass in factory().owner() in the above method instead, in the protocolFee clause
There was a problem hiding this comment.
I see - then should we also remove the fund method in the Factory since it's not longer possible to use it to claim the fees?
There was a problem hiding this comment.
yeah good catch let's remove that too
[Payoff] Integration Test Code Coverage ReportCoverage after merging arjun/claim-protocol-fee-to-owner into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Payoff] Unit Test Code Coverage ReportCoverage after merging arjun/claim-protocol-fee-to-owner into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Oracle] Unit Test Coverage ReportCoverage after merging arjun/claim-protocol-fee-to-owner into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Extensions] Unit Test Coverage ReportCoverage after merging arjun/claim-protocol-fee-to-owner into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||
[Core] Integration Test Coverage ReportCoverage after merging arjun/claim-protocol-fee-to-owner into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Extensions] Integration Test Coverage ReportCoverage after merging arjun/claim-protocol-fee-to-owner into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||
[Vault] Integration Test Coverage ReportCoverage after merging arjun/claim-protocol-fee-to-owner into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Core] Unit Test Coverage ReportCoverage after merging arjun/claim-protocol-fee-to-owner into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
kbrizzle
approved these changes
Aug 28, 2023
[Oracle] Integration Test Coverage ReportCoverage after merging arjun/claim-protocol-fee-to-owner into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This was referenced Sep 24, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.