[Fix] maker-minor funding allocation during socialization #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrizzle
force-pushed
the
britz-all-position-tests
branch
from
5013697 to
dd5800e
Compare
kbrizzle
changed the title
kbrizzle
changed the title
arjun-io
reviewed
Aug 11, 2023
| @@ -206,11 +206,11 @@ library VersionLib { | |||
|
|
|||
| // Redirect net portion of minor's side to maker | |||
| if (fromPosition.long.gt(fromPosition.short)) { | |||
| fundingValues.fundingMaker = fundingValues.fundingShort.mul(Fixed6Lib.from(fromPosition.skew().abs())); | |||
| fundingValues.fundingMaker = fundingValues.fundingShort.mul(Fixed6Lib.from(fromPosition.socializedSkew())); | |||
There was a problem hiding this comment.
This doesn't need an abs anymore?
There was a problem hiding this comment.
It's already abs inside the function. This is probably not the ideal name for the method, but I did include a dev comment on what it's doing.
kbrizzle
force-pushed
the
britz-all-position-tests
branch
from
7e50591 to
54c7a75
Compare
kbrizzle
force-pushed
the
britz-all-position-tests
branch
from
538e423 to
1c4d142
Compare
[Payoff] Integration Test Code Coverage ReportCoverage after merging britz-all-position-tests into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Extensions] Unit Test Coverage ReportCoverage after merging britz-all-position-tests into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||
[Payoff] Unit Test Code Coverage ReportCoverage after merging britz-all-position-tests into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Oracle] Unit Test Coverage ReportCoverage after merging britz-all-position-tests into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Oracle] Integration Test Coverage ReportCoverage after merging britz-all-position-tests into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Core] Integration Test Coverage ReportCoverage after merging britz-all-position-tests into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Vault] Integration Test Coverage ReportCoverage after merging britz-all-position-tests into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Core] Unit Test Coverage ReportCoverage after merging britz-all-position-tests into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Extensions] Integration Test Coverage ReportCoverage after merging britz-all-position-tests into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||
arjun-io
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken allocation of funding between markers and the minor side of the market when the market is in socialization.