Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect price exponentiation #53

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Fix incorrect price exponentiation #53

merged 2 commits into from
Jul 28, 2023

Conversation

arjun-io
Copy link
Collaborator

No description provided.

@arjun-io arjun-io requested review from kbrizzle and 0xfennel July 27, 2023 20:56
@github-actions
Copy link

[Payoff] Integration Test Code Coverage Report

Coverage after merging arjun/pyth-expo-fixes into main will be
100.00%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-payoff/contracts
   PayoffFactory.sol100%100%100%100%
packages/perennial-payoff/contracts/interfaces
   IPayoffFactory.sol100%100%100%100%
packages/perennial-payoff/contracts/payoff
   Giga.sol100%100%100%100%
   Kilo.sol100%100%100%100%
   KiloPowerHalf.sol100%100%100%100%
   KiloPowerTwo.sol100%100%100%100%
   Mega.sol100%100%100%100%
   MegaPowerTwo.sol100%100%100%100%
   Micro.sol100%100%100%100%
   MicroPowerTwo.sol100%100%100%100%
   Milli.sol100%100%100%100%
   MilliPowerHalf.sol100%100%100%100%
   MilliPowerTwo.sol100%100%100%100%
   Nano.sol100%100%100%100%
   PowerHalf.sol100%100%100%100%
   PowerTwo.sol100%100%100%100%

@github-actions
Copy link

[Payoff] Unit Test Code Coverage Report

Coverage after merging arjun/pyth-expo-fixes into main will be
100.00%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-payoff/contracts
   PayoffFactory.sol100%100%100%100%
packages/perennial-payoff/contracts/interfaces
   IPayoffFactory.sol100%100%100%100%
packages/perennial-payoff/contracts/payoff
   Giga.sol100%100%100%100%
   Kilo.sol100%100%100%100%
   KiloPowerHalf.sol100%100%100%100%
   KiloPowerTwo.sol100%100%100%100%
   Mega.sol100%100%100%100%
   MegaPowerTwo.sol100%100%100%100%
   Micro.sol100%100%100%100%
   MicroPowerTwo.sol100%100%100%100%
   Milli.sol100%100%100%100%
   MilliPowerHalf.sol100%100%100%100%
   MilliPowerTwo.sol100%100%100%100%
   Nano.sol100%100%100%100%
   PowerHalf.sol100%100%100%100%
   PowerTwo.sol100%100%100%100%

@github-actions
Copy link

[Extensions] Unit Test Coverage Report

Coverage after merging arjun/pyth-expo-fixes into main will be
83.74%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-extensions/contracts
   MultiInvoker.sol79.90%75%85.71%81.90%104, 143–144, 147–149, 151, 156, 222, 224, 233, 273, 273, 275, 278, 287, 287, 289, 292, 301, 303, 306, 314–315, 317, 343, 346–348, 363, 368, 391, 77, 80–82
packages/perennial-extensions/contracts/interfaces
   IMultiInvoker.sol100%100%100%100%
packages/perennial-extensions/contracts/types
   TriggerOrder.sol78.26%62.50%100%94.44%34–35, 61–68

@github-actions
Copy link

[Vault] Unit Test Coverage Report

Coverage after merging arjun/pyth-expo-fixes into main will be
32.12%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-vault/contracts
   Vault.sol0%0%0%0%104–105, 114, 116, 116, 116, 123, 125, 125, 125, 130, 130–131, 133–134, 134, 134, 137, 143, 143, 143–144, 144, 144, 146, 148–150, 157, 157–158, 160, 160, 160, 162–166, 171, 171–172, 174–175, 180, 180–183, 190, 190–192, 194–196, 209, 209–211, 213–216, 222–223, 223, 223–226, 228, 246, 246, 246–247, 247, 247, 250, 250, 250–252, 252, 252–254, 254, 254–256, 256, 256–258, 258, 258–260, 260, 260–261, 263, 263, 263, 266, 269–271, 274–276, 278, 292, 292, 292–294, 296, 296, 296, 301–302, 317, 321–324, 326, 332, 336, 336, 336, 340–342, 355, 357, 357, 357, 357, 357, 359, 365–366, 366, 366–369, 369, 369–370, 377, 380, 382, 392, 406, 408–411, 413, 415–418, 421–422, 424–427, 430–431, 434–435, 438–440, 447–449, 456, 456, 456–458, 466, 466, 466, 468–471, 473, 473, 473, 473, 473, 475, 480, 487–489, 499–501, 503–505, 58, 58–59, 61–63, 69, 76, 83, 89, 95–96
   VaultFactory.sol0%0%0%0%23, 27, 27–28, 40, 40–42, 49–50
packages/perennial-vault/contracts/interfaces
   IVault.sol100%100%100%100%
   IVaultFactory.sol100%100%100%100%
packages/perennial-vault/contracts/lib
   StrategyLib.sol0%0%0%0%101–104, 106, 108–109, 111–112, 126–128, 137, 64–66, 68, 70–73, 76, 80, 80, 80–81, 81, 85, 87
packages/perennial-vault/contracts/types
   Account.sol100%100%100%100%
   Checkpoint.sol100%100%100%100%
   Mapping.sol100%100%100%100%
   Registration.sol100%100%100%100%
   VaultParameter.sol100%100%100%100%

@github-actions
Copy link

[Oracle] Unit Test Coverage Report

Coverage after merging arjun/pyth-expo-fixes into main will be
48.91%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-oracle/contracts
   Oracle.sol100%100%100%100%
   OracleFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/interfaces
   IOracle.sol100%100%100%100%
   IOracleFactory.sol100%100%100%100%
   IPythFactory.sol100%100%100%100%
   IPythOracle.sol100%100%100%100%
packages/perennial-oracle/contracts/pyth
   PythFactory.sol0%0%0%0%104, 104–106, 113–115, 115, 115–116, 38–39, 44, 44–45, 47–48, 53, 53–54, 60, 60–61, 63, 65, 72–73, 73, 76, 82, 87, 87–89, 89, 89–90, 90, 90–91, 91, 91, 93, 98
   PythOracle.sol0%0%0%0%101, 109–110, 116, 116, 116, 116, 116–117, 127, 127, 132, 132, 132–133, 133, 133, 135–136, 138, 138, 138–139, 142, 142, 142–143, 145, 145, 145, 148, 148, 148, 154–156, 167, 167, 167–169, 172, 175, 175, 175, 177–178, 185–188, 190, 202–204, 204, 206, 212, 217, 217, 217–218, 59, 66, 66–68, 70, 70, 70, 72, 77, 77–78, 78, 78, 78, 78–79, 87, 93, 93, 93, 95

@github-actions
Copy link

[Oracle] Integration Test Coverage Report

Coverage after merging arjun/pyth-expo-fixes into main will be
100.00%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-oracle/contracts
   Oracle.sol100%100%100%100%
   OracleFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/interfaces
   IOracle.sol100%100%100%100%
   IOracleFactory.sol100%100%100%100%
   IPythFactory.sol100%100%100%100%
   IPythOracle.sol100%100%100%100%
packages/perennial-oracle/contracts/pyth
   PythFactory.sol88.68%70%100%100%104, 115, 44, 53, 60, 87
   PythOracle.sol94.90%86.84%100%100%127, 204, 217, 66, 78

@github-actions
Copy link

[Core] Integration Test Coverage Report

Coverage after merging arjun/pyth-expo-fixes into main will be
92.34%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial/contracts
   Market.sol76.17%57%88.57%85.28%100–101, 106, 113, 120–122, 131, 133, 133, 133–134, 134, 134–136, 136, 136–137, 137, 137, 139, 146, 146, 146, 148–150, 155, 157–158, 160–161, 252–254, 393, 437, 475–476, 476, 476, 476, 485–486, 491–492, 494–495, 499, 505–506, 506, 515, 519, 530, 536–537, 554–555, 60, 603, 608, 83, 92, 99, 99
   MarketFactory.sol60.53%42.86%71.43%70.59%37, 48, 57–58, 64, 66, 72, 75–76, 88, 88, 88–89
packages/perennial/contracts/interfaces
   IMarket.sol100%100%100%100%
   IMarketFactory.sol100%100%100%100%
   IOracleProvider.sol100%100%100%100%
   IOracleProviderFactory.sol100%100%100%100%
   IPayoffProvider.sol100%100%100%100%
packages/perennial/contracts/types
   Global.sol78.57%50%100%100%114–125
   Local.sol80%56.25%83.33%95.65%127–132, 89, 97
   MarketParameter.sol69.57%40.91%100%95%112, 114–115, 117, 119, 121, 121, 121, 121, 133–137
   OracleVersion.sol100%100%100%100%
   Order.sol86.96%62.50%100%100%73, 79, 98
   Position.sol90.68%60.71%100%100%265, 433–442
   ProtocolParameter.sol73.08%50%100%100%59–65
   RiskParameter.sol73.91%50%100%100%164, 169, 174, 176, 181, 183, 185, 187, 197–200
   Version.sol90.18%70.59%100%98.57%191–192, 360–368

@github-actions
Copy link

[Extensions] Integration Test Coverage Report

Coverage after merging arjun/pyth-expo-fixes into main will be
99.19%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-extensions/contracts
   MultiInvoker.sol96.91%91.18%100%100%156, 275, 289, 343, 363, 77
packages/perennial-extensions/contracts/interfaces
   IMultiInvoker.sol100%100%100%100%
packages/perennial-extensions/contracts/types
   TriggerOrder.sol89.13%83.33%100%94.44%34–35, 61–63

@github-actions
Copy link

[Vault] Integration Test Coverage Report

Coverage after merging arjun/pyth-expo-fixes into main will be
98.91%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-vault/contracts
   Vault.sol96.84%94.12%96.67%98.06%180, 180–183, 247, 263
   VaultFactory.sol85.71%50%100%100%27, 40
packages/perennial-vault/contracts/interfaces
   IVault.sol100%100%100%100%
   IVaultFactory.sol100%100%100%100%
packages/perennial-vault/contracts/lib
   StrategyLib.sol100%100%100%100%
packages/perennial-vault/contracts/types
   Account.sol82.86%50%100%100%126–131
   Checkpoint.sol88.64%68.75%100%100%132, 186, 224–231
   Mapping.sol95.12%80%100%100%100, 95
   Registration.sol81.82%50%100%100%41–42
   VaultParameter.sol87.50%50%100%100%31

@github-actions
Copy link

[Core] Unit Test Coverage Report

Coverage after merging arjun/pyth-expo-fixes into main will be
99.76%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial/contracts
   Market.sol99.66%99%100%100%83
   MarketFactory.sol100%100%100%100%
packages/perennial/contracts/interfaces
   IMarket.sol100%100%100%100%
   IMarketFactory.sol100%100%100%100%
   IOracleProvider.sol100%100%100%100%
   IOracleProviderFactory.sol100%100%100%100%
   IPayoffProvider.sol100%100%100%100%
packages/perennial/contracts/types
   Global.sol100%100%100%100%
   Local.sol95.56%100%83.33%95.65%97
   MarketParameter.sol100%100%100%100%
   OracleVersion.sol100%100%100%100%
   Order.sol100%100%100%100%
   Position.sol100%100%100%100%
   ProtocolParameter.sol100%100%100%100%
   RiskParameter.sol100%100%100%100%
   Version.sol100%100%100%100%

@arjun-io arjun-io merged commit fcb4c75 into main Jul 28, 2023
@arjun-io arjun-io deleted the arjun/pyth-expo-fixes branch July 28, 2023 22:22
@arjun-io arjun-io mentioned this pull request Aug 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbrizzle kbrizzle kbrizzle approved these changes

@0xfennel 0xfennel Awaiting requested review from 0xfennel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arjun-io @kbrizzle