[Fix] Oracle update permissioning

equilibria-xyz · Aug 25, 2023 · 35b188d · 35b188d
1 parent 0421a66
commit 35b188d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/packages/perennial-oracle/contracts/Oracle.sol b/packages/perennial-oracle/contracts/Oracle.sol
@@ -25,7 +25,8 @@ contract Oracle is IOracle, Instance {
 
     /// @notice Updates the current oracle provider
     /// @param newProvider The new oracle provider
-    function update(IOracleProvider newProvider) external onlyOwner {
+    function update(IOracleProvider newProvider) external {
+        if (msg.sender != address(factory())) revert OracleNotFactoryError();
         _updateCurrent(newProvider);
         _updateLatest(newProvider.latest());
     }

diff --git a/packages/perennial-oracle/contracts/interfaces/IOracle.sol b/packages/perennial-oracle/contracts/interfaces/IOracle.sol
@@ -5,6 +5,7 @@ import "@equilibria/root/attribute/interfaces/IInstance.sol";
 import "@equilibria/perennial-v2/contracts/interfaces/IOracleProvider.sol";
 
 interface IOracle is IOracleProvider, IInstance {
+    error OracleNotFactoryError();
     error OracleOutOfSyncError();
     error OracleOutOfOrderCommitError();
 

diff --git a/packages/perennial-oracle/test/unit/oracle/Oracle.test.ts b/packages/perennial-oracle/test/unit/oracle/Oracle.test.ts
@@ -115,7 +115,7 @@ describe('Oracle', () => {
 
     context('updates the oracle w/o sync', async () => {
       beforeEach(async () => {
-        await expect(oracle.connect(owner).update(underlying1.address))
+        await expect(oracle.connect(oracleFactorySigner).update(underlying1.address))
           .to.emit(oracle, 'OracleUpdated')
           .withArgs(underlying1.address)
       })