Skip to content

remove magic values #2174

remove magic values

remove magic values #2174

Re-run triggered December 17, 2024 16:43
Status Success
Total duration 42m 47s
Artifacts 12

CI.yml

on: pull_request
[Core] Unit Tests w/ Coverage
1h 53m
[Core] Unit Tests w/ Coverage
[Core] Integration Tests w/ Coverage
33m 58s
[Core] Integration Tests w/ Coverage
[Oracle] Integration Tests w/ Coverage
28m 30s
[Oracle] Integration Tests w/ Coverage
[Oracle] Sepolia Integration Tests w/ Coverage
4m 46s
[Oracle] Sepolia Integration Tests w/ Coverage
[Vault] Integration Tests w/ Coverage
40m 54s
[Vault] Integration Tests w/ Coverage
[Periphery] Mainnet Integration Tests w/ Coverage
9m 52s
[Periphery] Mainnet Integration Tests w/ Coverage
[Oracle] Unit Tests w/ Coverage
3m 36s
[Oracle] Unit Tests w/ Coverage
[Vault] Unit Tests w/ Coverage
2m 50s
[Vault] Unit Tests w/ Coverage
[Periphery] Unit Tests w/ Coverage
3m 21s
[Periphery] Unit Tests w/ Coverage
Lint
1m 16s
Lint
[Periphery] L2 Integration Tests w/ Coverage
20m 20s
[Periphery] L2 Integration Tests w/ Coverage
[Core] Combined Tests w/ Coverage
28s
[Core] Combined Tests w/ Coverage
Periphery Integration Tests Coverage
18s
Periphery Integration Tests Coverage
Periphery Unit Tests Coverage
38s
Periphery Unit Tests Coverage
Periphery Combined Tests Coverage
1m 4s
Periphery Combined Tests Coverage
Fit to window
Zoom out
Zoom in

Annotations

26 warnings
Lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Lint: packages/core/test/helpers/erc712.ts#L13
Missing return type on function
Lint: packages/core/test/integration/core/closedProduct.test.ts#L4
'AddressZero' is assigned a value but never used
Lint: packages/core/test/integration/core/closedProduct.test.ts#L24
'beneficiaryB' is assigned a value but never used
Lint: packages/core/test/integration/core/closedProduct.test.ts#L52
'beneficiaryB' is assigned a value but never used
Lint: packages/core/test/integration/core/closedProduct.test.ts#L96
'beneficiaryB' is assigned a value but never used
Lint: packages/core/test/integration/core/closedProduct.test.ts#L125
'LIQUIDATION_FEE' is assigned a value but never used
Lint: packages/core/test/integration/core/closedProduct.test.ts#L139
'beneficiaryB' is assigned a value but never used
Lint: packages/core/test/integration/core/closedProduct.test.ts#L176
'LIQUIDATION_FEE' is assigned a value but never used
Lint: packages/core/test/integration/core/fees.test.ts#L4
'AddressZero' is assigned a value but never used
Lint: packages/core/test/integration/core/fees.test.ts#L95
Forbidden non-null assertion
[Oracle] Sepolia Integration Tests w/ Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[Core] Unit Tests w/ Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[Core] Integration Tests w/ Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[Oracle] Unit Tests w/ Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[Periphery] L2 Integration Tests w/ Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[Oracle] Integration Tests w/ Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[Periphery] Unit Tests w/ Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[Periphery] Mainnet Integration Tests w/ Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[Vault] Unit Tests w/ Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Periphery Unit Tests Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[Core] Combined Tests w/ Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[Vault] Integration Tests w/ Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Periphery Integration Tests Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Periphery Combined Tests Coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "core_integration_test_coverage", "core_unit_test_coverage", "oracle_integration_test_coverage", "oracle_sepolia_integration_test_coverage", "oracle_unit_test_coverage", "periphery_arbitrum_integration_test_coverage", "periphery_integration_coverage", "periphery_integration_test_coverage", "periphery_unit_coverage", "periphery_unit_test_coverage", "vault_integration_test_coverage", "vault_unit_test_coverage". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
core_integration_test_coverage
29.2 KB
core_unit_test_coverage
29.4 KB
oracle_integration_test_coverage
12.5 KB
oracle_sepolia_integration_test_coverage
12.1 KB
oracle_unit_test_coverage
12 KB
periphery_arbitrum_integration_test_coverage
20.8 KB
periphery_integration_coverage
29.2 KB
periphery_integration_test_coverage
20.5 KB
periphery_unit_coverage
27.8 KB
periphery_unit_test_coverage
20.6 KB
vault_integration_test_coverage
9.33 KB
vault_unit_test_coverage
8.45 KB