Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compute_contract_hash_example argument index #2396

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

vbar
Copy link
Contributor

@vbar vbar commented Nov 21, 2024

was off by one (b/c it was incremented to make it 1-based, twice), plus checked as if it was 0-based.

@vbar vbar requested a review from a team as a code owner November 21, 2024 08:34
Copy link
Contributor

@kkovaacs kkovaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vbar vbar merged commit c1a22c9 into main Nov 22, 2024
7 checks passed
@vbar vbar deleted the vbar/contract-state-hash-example branch November 22, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants