Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p sync tests #2394

Merged
merged 29 commits into from
Nov 27, 2024
Merged

p2p sync tests #2394

merged 29 commits into from
Nov 27, 2024

Conversation

CHr15F0x
Copy link
Member

@CHr15F0x CHr15F0x commented Nov 20, 2024 •
edited
Loading

Fixes: #2300

  • fake block generation now includes tries, respective commitments, and signatures
  • some fixtures removed
  • added an integration test with 3 cases:
    • full sync, recoverable errors triggered in each stage (ie. headers, transactions, ...) separately for checkpoint and track sync
    • full sync, interrupted by a fatal error during checkpoint sync
    • full sync, interrupted by a fatal error during tracking sync
  • removed a redundant test
  • enable signature verification in p2p sync
  • other minor fixes and refactors

@CHr15F0x CHr15F0x force-pushed the chris/sync-tests2 branch 7 times, most recently from cd46651 to 26e6870 Compare November 22, 2024 18:34
@CHr15F0x CHr15F0x changed the title Chris/sync tests2 p2p sync tests Nov 22, 2024
@CHr15F0x CHr15F0x marked this pull request as ready for review November 22, 2024 19:14
@CHr15F0x CHr15F0x requested a review from a team as a code owner November 22, 2024 19:14
@CHr15F0x CHr15F0x force-pushed the chris/sync-tests2 branch 2 times, most recently from e120fe3 to 6c4697a Compare November 25, 2024 05:39
@CHr15F0x
Copy link
Member Author

Transient test failure due to the fgw.

kkovaacs
kkovaacs approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@kkovaacs kkovaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

t00ts
t00ts reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@t00ts t00ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CHr15F0x CHr15F0x merged commit 21c6c45 into main Nov 27, 2024
7 checks passed
@CHr15F0x CHr15F0x deleted the chris/sync-tests2 branch November 27, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t00ts t00ts t00ts left review comments

@kkovaacs kkovaacs kkovaacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests for tracking and checkpoint sync
3 participants
@CHr15F0x @kkovaacs @t00ts