IP whitelist #1698
Merged
IP whitelist #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHr15F0x
reviewed
Jan 24, 2024
crates/p2p/src/behaviour.rs
Outdated
| .iter() | ||
| .any(|net| net.contains(&peer_ip)) | ||
| { | ||
| tracing::debug!(%connection_id, "Disconnected peer not in IP whitelist"); |
There was a problem hiding this comment.
nit: connection_id not so informative, maybe add peer_ip here since it's available anyway?
Mirko-von-Leipzig
approved these changes
Jan 25, 2024
kkovaacs
approved these changes
Jan 25, 2024
sistemd
force-pushed
the
sistemd/p2p-ip-whitelist
branch
from
8a71373 to
e933242
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional IP whitelisting. By default all IP addresses are whitelisted.
Part of #1670.