feat(p2p_proto): remove redundant address fields #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHr15F0x
commented
Jan 11, 2024
CHr15F0x
force-pushed
the
chris/rm-addr-in-depl-acc
branch
2 times, most recently
from
179c94b to
507eb07
Compare
CHr15F0x
force-pushed
the
chris/rm-addr-in-depl-acc
branch
from
507eb07 to
b3709d7
Compare
Co-authored-by: Krisztian Kovacs <[email protected]>
sistemd
reviewed
Jan 19, 2024
crates/p2p/Cargo.toml
Outdated
| @@ -37,6 +37,7 @@ pathfinder-common = { path = "../common" } | |||
| pathfinder-crypto = { path = "../crypto" } | |||
| prost = "0.12.1" | |||
| rand = { workspace = true } | |||
| rayon = "1.8.0" | |||
There was a problem hiding this comment.
This should become a workspace dep I think.
Mirko-von-Leipzig
approved these changes
Jan 19, 2024
CHr15F0x
force-pushed
the
chris/rm-addr-in-depl-acc
branch
from
7b71efd to
112d488
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added those fields in anticipation of a spec update but it turns out I didn't notice these fields are redundant and can just be computed locally.
Edit: I updated the code to defer computing those addresses after all other parsing is done.