Fixes to rolling and time-varying methods #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update documentation and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #95 and #97.
cfr_rolling()has been updated to follow a similar logic tocfr_time_varying(), where thebinom.testfunction is only run on data indices where cumulative cases >= cumulative deaths, and cumulative cases > 0,cfr_rolling()has been updated to have the same return format ascfr_time_varying(),known_outcomes()has been updated to account forNaNfrom zero divisions (see Renameknown_outcomes()toestimate_outcomes()#93 as well),estimate_severity()has been updated to deal with any two of total cases, deaths or outcomes being 0.