Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ascertainment vignette #74

Merged
merged 8 commits into from
Aug 16, 2023
Merged

Fix ascertainment vignette #74

merged 8 commits into from
Aug 16, 2023

Conversation

pratikunterwegs
Copy link
Collaborator

@pratikunterwegs pratikunterwegs commented Aug 14, 2023

This PR:

  1. Corrects the ascertainment vignette by re-adding filtering for early stages of the outbreak, and fixes Odd results in ascertainment plots in estimate_ascertainment.Rmd vignette #73,
  2. Fixes excessive data output by showing the last few rows,
  3. Fixes activate alert boxes in static_severity vignette #70 by correcting heading levels,
  4. Cleans up plot style in all figures.

@pratikunterwegs
Copy link
Collaborator Author

Is this more like it @adamkucharski? - Looks familiar from older vignettes.
Rplot

Copy link
Member

@adamkucharski adamkucharski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have one comment about omitting countries without weekly data, but otherwise looks good.

# nest the data
df_reporting <- nest(covid_data, .by = country)
df_reporting <- nest(covid_data_early, .by = country)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks more plausible for most countries, but looking at the remaining 100% estimates (i.e. Spain, Germany, France, Ukraine), it's happening because the data for those four countries are only weekly, but the underascertainment algorithm (and underlying CFR calculation) is designed for daily data, which is why it's returning an erroneous result. I'd therefore suggest we omit these countries with a brief note to user about why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, so that's what's going on - I thought it might be that they actually have really good reporting. I'll exclude these countries from the vignettes, but are they perhaps worth keeping in the dataset? Is there a way to modify the current methods to deal with low-frequency reporting?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted to issue - happy to discuss further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants