Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes prior to release #72

Merged
merged 7 commits into from
Aug 14, 2023
Merged

Fixes prior to release #72

merged 7 commits into from
Aug 14, 2023

Conversation

pratikunterwegs
Copy link
Collaborator

This PR implements fixes prior to release and is addressing issues in #68.

  1. Data from {covidregionaldata} are included in the package to replace data from {owidR}, fixes Add data for examples to package #71

@pratikunterwegs pratikunterwegs marked this pull request as ready for review August 14, 2023 10:09
adamkucharski
adamkucharski reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@adamkucharski adamkucharski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a couple of errors with filtering on column names in the vignettes – not sure if something just hasn't updated or stored?

vignettes/estimate_ascertainment.Rmd Outdated Show resolved Hide resolved
vignettes/estimate_ascertainment.Rmd Outdated Show resolved Hide resolved
vignettes/estimate_ascertainment.Rmd Show resolved Hide resolved
vignettes/estimate_time_varying_severity.Rmd Show resolved Hide resolved
adamkucharski
adamkucharski approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@adamkucharski adamkucharski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vignettes now running, thanks for the check.

@pratikunterwegs pratikunterwegs merged commit 55a3450 into main Aug 14, 2023
@pratikunterwegs pratikunterwegs deleted the dev/prep-release branch August 14, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkucharski adamkucharski adamkucharski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add data for examples to package
3 participants
@pratikunterwegs @adamkucharski @actions-user