Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package to {cfr} #54

Merged
merged 11 commits into from
Jul 13, 2023
Merged

Rename package to {cfr} #54

merged 11 commits into from
Jul 13, 2023

Conversation

pratikunterwegs
Copy link
Collaborator

@pratikunterwegs pratikunterwegs commented Jul 12, 2023

This PR renames the package to {cfr} from {datadelay}, and fixes #47.

This PR also:

  1. Adds a package logo with the new name, and fixes Add package logo #53,
  2. Updates the pkg maintainer to @pratikunterwegs, and adds @TimTaylor, @joshwlambert, and @Bisaloo as reviewers - could you please say whether you're okay with this.

Copy link
Member

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please submit PRs to:

  • the r-universe repo to update the pkg name and link
  • the hex-stickers repo with the logo in png & svg

@@ -8,3 +8,4 @@ inst/doc
/doc/
/Meta/
scratch.R
pkgdown/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This folder can contain important files we want to commit. Do you have any issues that lead you to add it here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it only contains the directoy favicon/ with icons of different sizes - should these be committed? I can allow tracking if so.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converting this to an issue for now - can be added to tracking if it becomes necessary, but I don't see a pkgdown directory in our other repos so keeping it out for now.

R/prepare_data.R Outdated Show resolved Hide resolved
@pratikunterwegs pratikunterwegs marked this pull request as ready for review July 13, 2023 10:36
@pratikunterwegs pratikunterwegs merged commit 5206bd4 into main Jul 13, 2023
@pratikunterwegs pratikunterwegs deleted the dev/pkg-rename branch July 13, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add package logo Rename package
3 participants