-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename package to {cfr} #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also please submit PRs to:
- the r-universe repo to update the pkg name and link
- the hex-stickers repo with the logo in png & svg
@@ -8,3 +8,4 @@ inst/doc | |||
/doc/ | |||
/Meta/ | |||
scratch.R | |||
pkgdown/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This folder can contain important files we want to commit. Do you have any issues that lead you to add it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently it only contains the directoy favicon/
with icons of different sizes - should these be committed? I can allow tracking if so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converting this to an issue for now - can be added to tracking if it becomes necessary, but I don't see a pkgdown
directory in our other repos so keeping it out for now.
Co-authored-by: Hugo Gruson <[email protected]>
This PR renames the package to {cfr} from {datadelay}, and fixes #47.
This PR also: