Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release fixes #104

Merged
merged 51 commits into from
Nov 21, 2023
Merged

Pre-release fixes #104

merged 51 commits into from
Nov 21, 2023

Conversation

pratikunterwegs
Copy link
Collaborator

@pratikunterwegs pratikunterwegs commented Nov 10, 2023

This PR makes pre-release fixes:

  1. Updates to functions to allow counts rather than strict integers, with distinctions between functions in whether 0s are allowed or not,
  2. Updates to function documentation with links to parameter sources,
  3. Updates to README to add install instructions, fix urls, and correct workflow,
  4. Guard tests against noSuggests runs on CRAN; this issue still affects the vignettes so the addition is moot,
  5. Adds NEWS and CRAN comments files

Changes from code review in #103

  1. Fixes Single convolution function for cases and PMFs #106 by adding the function .convolve_cases_pmfs(),
  2. Fixes Test for bias due to index shifting #108 by adding tests for cfr_time_varying()

@pratikunterwegs
Copy link
Collaborator Author

Snapshots tests for ascertainment failing as ascertainment is much higher; this is noted and being looked into.

Copy link

This pull request:

  • Adds 0 new dependencies (direct and indirect)
  • Adds 0 new system dependencies
  • Removes 1 existing dependencies (direct and indirect)
  • Removes 1 existing system dependencies

(cc @Bisaloo for workflow monitoring)

@epiverse-trace epiverse-trace deleted a comment from github-actions bot Nov 20, 2023
@epiverse-trace epiverse-trace deleted a comment from github-actions bot Nov 20, 2023
@epiverse-trace epiverse-trace deleted a comment from github-actions bot Nov 20, 2023
@epiverse-trace epiverse-trace deleted a comment from github-actions bot Nov 20, 2023
@epiverse-trace epiverse-trace deleted a comment from github-actions bot Nov 20, 2023
@epiverse-trace epiverse-trace deleted a comment from github-actions bot Nov 20, 2023
@epiverse-trace epiverse-trace deleted a comment from github-actions bot Nov 20, 2023
@epiverse-trace epiverse-trace deleted a comment from github-actions bot Nov 20, 2023
@epiverse-trace epiverse-trace deleted a comment from github-actions bot Nov 20, 2023
@epiverse-trace epiverse-trace deleted a comment from github-actions bot Nov 20, 2023
@epiverse-trace epiverse-trace deleted a comment from github-actions bot Nov 20, 2023
@pratikunterwegs
Copy link
Collaborator Author

Deleting comments from the GH dependencies action bot. One comment retained for information re: {outbreaks} pkg removed.

@pratikunterwegs pratikunterwegs merged commit e8a85a3 into main Nov 21, 2023
9 checks passed
@pratikunterwegs pratikunterwegs deleted the dev/fixes branch November 21, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test for bias due to index shifting Single convolution function for cases and PMFs
2 participants