Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 36: Add benchmarking of R, Stan, and fitdistdoublecens #79

Merged
merged 12 commits into from
Sep 17, 2024
Merged

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Sep 17, 2024

Description

This PR closes #36.

Adds touchstone based benchmarking for:

  • R side functionality
  • pcens_model.stan
  • fitdistdoublecens()

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (908dd08) to head (d3b95e3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files           8        8           
  Lines         310      310           
=======================================
  Hits          309      309           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs seabbs marked this pull request as ready for review September 17, 2024 16:10
Copy link
Contributor Author

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (self-review)

@seabbs seabbs merged commit c69543d into main Sep 17, 2024
12 checks passed
@seabbs seabbs deleted the touchstone branch September 17, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add touchstone benchmarking of core functionality
1 participant