Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 37 draft: Why it works vignette with analytic solutions #68
Issue 37 draft: Why it works vignette with analytic solutions #68
Changes from 16 commits
4b7a02c
dc94f53
b060945
0f591af
5733e25
37e7f18
ca16908
c47c2d6
7bd8cf4
fd2ac18
9d039aa
b05b238
06e1a16
e8a1d78
85c8667
ea269fa
308141b
ddd5c64
dd79913
8917703
cba034b
e66a0ac
dcfd976
694e16b
dd29b60
991407a
3db8aeb
27c98ed
5fa6b9b
917ab7e
6120812
62ec9ed
05daf84
9df87c0
8059534
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing f_T def
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To link across with the docs I think here we should connect it to the formulation give in the getting started clearly and the same goes for the pmf section below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Say something like with this in hand, all very standard blah blah (and link to something - maybe stan docs on censoring)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link to getting started
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this currently feels like somewhat of a random aside. If it is can it go after the main thrust of your point and some text added to explain why we care.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this gain you apart from 74? line 74 doesn't seem that useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It pops up a lot in the analytic solutions, I wasn't going to add new notation but then I realised that for the uniform primary censor window to basic delay pmf comes in a standard form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe introduce it in the analytical section then (perhaps even as a helpful ideas section or similar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link to our implementation? (i.e code docs [rexpgrowth()].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add ref to exponetial titled uniform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bit more on what this means (i.e no circadian pattern etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 is still a WIP I would assume (and fair enough) For now shall we drop just so we can merge this sooner rather than later and add in 2. via a new issue and PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. That makes sense. Mostly, its not hard to extend solutions to situation 2) except that for log-normal dist where the maths is really helped by cancelling the$\frac{1}{z}$ factor in the pdf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by parts blah blah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not start from the last derived section here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref (wikipedia)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a few more steps here for people would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just go directly to this line and say subbing into blah blah previous equation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. cite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also subbing into to equation blah blah blah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't actually know a citation for this. I put "The log-normal integration trick" as a bit of a placeholder. I'll try and find a ref, its pretty obvs once you spot it.