Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct specification of empty array #186

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Use correct specification of empty array #186

merged 4 commits into from
Dec 13, 2024

Conversation

jamesmbaazam
Copy link
Contributor

Description

This PR closes #170.

[Describe the changes that you made in this pull request.]

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@jamesmbaazam
Copy link
Contributor Author

My little contribution.

seabbs
seabbs previously approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. One small suggestion. Can you also add yourself as a contributor

@jamesmbaazam
Copy link
Contributor Author

Nice. One small suggestion. Can you also add yourself as a contributor

Done. I'll familiarise myself with the package and see where I can contribute in the new year.

seabbs
seabbs approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing :) I think there is likely to be a fair few things that crop up when we integrate this into the backend of EpiNow2.

@seabbs seabbs merged commit f961b89 into epinowcast:main Dec 13, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to define empty array for Stan
2 participants
@jamesmbaazam @seabbs