Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #84: Prune not helpful to arg flow maths #116

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Issue #84: Prune not helpful to arg flow maths #116

merged 2 commits into from
Oct 4, 2024

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Oct 4, 2024

Description

This PR closes #84. It removes some lines of maths that don't seem useful to the reader and weren't in all analytical solutions. It also removes the acknowledgement section from the vignette as we already have this contribution flagged via the all contributors bot.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@seabbs seabbs requested a review from SamuelBrand1 October 4, 2024 14:47
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.29%. Comparing base (7180ddc) to head (8aa738b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files          10       10           
  Lines         427      427           
=======================================
  Hits          424      424           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs seabbs merged commit 442370f into main Oct 4, 2024
10 checks passed
@seabbs seabbs deleted the issue84 branch October 4, 2024 15:22
@seabbs
Copy link
Contributor Author

seabbs commented Oct 4, 2024

LGTM (self-review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check why it works for maths lines we can do without
1 participant