Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heuristics when the relative_obs_time is much bigger than the maximum observed delay #69

Closed
seabbs opened this issue Sep 16, 2024 · 0 comments · Fixed by #120
Closed
Assignees

Comments

@seabbs
Copy link
Contributor

seabbs commented Sep 16, 2024

Compute time in both R and stan scales with unique combinations. We can reduce these by providing a heuristic when D is much longer than the maximum specified delay for that D. This is because when this is the case it is unlikely that truncation is playing a role and so the user can safely set D to inf here (in a large data set this could hugely reduce the number of unique combinations and hence run time).

I think it makes sense to do this on the stan side via the data preprocessing in pcd_as_cmdstan_data() with both a function to message a warning and a function to alter D and combine now non-unique pairings.

On the R side, I am less clear what this looks like. This was motivated by exploring performance in #67

@seabbs seabbs self-assigned this Oct 4, 2024
seabbs added a commit that referenced this issue Oct 4, 2024
* add check_truncation

* add unit tests

* add truncation checking to model functions

* add news and rename

* include new news item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant