Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use local environment for fitdist call #113

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Oct 4, 2024

With reference to #62 (comment) shouldn't this work? (tested locally it does but might be missing some complexity).

@sbfnk sbfnk requested a review from seabbs October 4, 2024 10:51
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.76%. Comparing base (1dbaf5f) to head (79c0c6b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   99.76%   99.76%   -0.01%     
==========================================
  Files          10       10              
  Lines         427      424       -3     
==========================================
- Hits          426      423       -3     
  Misses          1        1              
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbfnk sbfnk marked this pull request as ready for review October 4, 2024 11:09
@seabbs
Copy link
Contributor

seabbs commented Oct 4, 2024

Nice this does look like it works though I find this confusing as I tested nearly the same approach with withr (maybe nearly is the key point)!

@seabbs
Copy link
Contributor

seabbs commented Oct 4, 2024

Checked this out locally and it does work. I have no idea why it wasn't before. Updated this to add you as a contributor and update the news. Thanks for checking this out!

@seabbs seabbs merged commit f61f379 into main Oct 4, 2024
9 of 10 checks passed
@seabbs seabbs deleted the fitdist-local-environment branch October 4, 2024 12:11
@sbfnk
Copy link
Contributor Author

sbfnk commented Oct 4, 2024

Do we need to add a requireNamespace() check for withr to the head of the function?

@seabbs
Copy link
Contributor

seabbs commented Oct 4, 2024

yes

@seabbs
Copy link
Contributor

seabbs commented Oct 4, 2024

I'll hotfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate alternatives to global environment assignment in fitdistdoublecens
2 participants