Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate alternatives to global environment assignment in fitdistdoublecens #62

Closed
seabbs opened this issue Sep 10, 2024 · 7 comments · Fixed by #113
Closed

Investigate alternatives to global environment assignment in fitdistdoublecens #62

seabbs opened this issue Sep 10, 2024 · 7 comments · Fixed by #113
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@seabbs
Copy link
Contributor

seabbs commented Sep 10, 2024

As the title and as flagged in #61. There are two options I see:

  • Find a work around
  • Submit a issue/PR to fitdistrplus to change the way that it (optionally) finds custom distribution functions.

I think the current implementation is not CRAN compliant and so I think this needs to be resolved before CRAN submission.

@seabbs seabbs added bug Something isn't working help wanted Extra attention is needed labels Sep 10, 2024
@seabbs
Copy link
Contributor Author

seabbs commented Sep 11, 2024

Perhaps just using withr would be enough.

@seabbs
Copy link
Contributor Author

seabbs commented Sep 16, 2024

I tried with withr::with_environment and that didn't seem to work.

@seabbs
Copy link
Contributor Author

seabbs commented Sep 16, 2024

Submit a issue/PR to fitdistrplus to change the way that it (optionally) finds custom distribution functions.

I'm currently favouring this I think

@seabbs
Copy link
Contributor Author

seabbs commented Sep 30, 2024

@Bisaloo any chance you have any good ideas here? I think this is blocking a CRAN release but its also really useful functionality for people who can't/don't want to use CRAN.

@seabbs
Copy link
Contributor Author

seabbs commented Sep 30, 2024

This is the assignment I can't find a way around

@seabbs
Copy link
Contributor Author

seabbs commented Oct 3, 2024

Issue over on fitdistrplus: lbbe-software/fitdistrplus#33

@seabbs
Copy link
Contributor Author

seabbs commented Oct 3, 2024

@sbfnk sbfnk linked a pull request Oct 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant