Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primarycensoreddist -> primarycensored #108

Closed
seabbs opened this issue Sep 27, 2024 · 9 comments · Fixed by #130
Closed

primarycensoreddist -> primarycensored #108

seabbs opened this issue Sep 27, 2024 · 9 comments · Fixed by #130
Labels
documentation Improvements or additions to documentation

Comments

@seabbs
Copy link
Contributor

seabbs commented Sep 27, 2024

We now have a Julia version of this tool that is called PrimaryCensored to fit with the naming approach take in Distributions.jl does this mean we should consider renaming this to primarycensored (and so renaming all the functions that currently use dist as well or are we happy with these having slightly different names?

@seabbs seabbs added the question Further information is requested label Sep 27, 2024
@athowes
Copy link
Contributor

athowes commented Oct 1, 2024

I prefer shorter version and think primarycensoreddist is a mouthful.

@seabbs
Copy link
Contributor Author

seabbs commented Oct 1, 2024

This doesn't introduce a docs clash as the julia tooling is moving to PrimaryCensored.EpiAware.org

@athowes

This comment was marked as off-topic.

@seabbs

This comment was marked as off-topic.

@athowes

This comment was marked as off-topic.

@seabbs

This comment was marked as off-topic.

@athowes

This comment was marked as off-topic.

@seabbs

This comment was marked as off-topic.

@seabbs seabbs changed the title primarycensoreddist -> primarycensored? primarycensoreddist -> primarycensored Oct 4, 2024
@seabbs seabbs added documentation Improvements or additions to documentation and removed question Further information is requested labels Oct 4, 2024
@seabbs
Copy link
Contributor Author

seabbs commented Oct 4, 2024

I think the current conclusion is yes we should do this so moving from a question to issue. We need to:

  • Find and replace the package name everywhere
  • Look for dist naming and change to match dropping this from the name of the package
  • Update the hexsticker
  • Change the repository name
  • Change the redirect on square space (@seabbs)
  • Add a redirect to link from the current web docs to the new one.
  • Add a news item communication this breaking change.
  • Communicate with key stakeholders that this has happened

seabbs added a commit that referenced this issue Oct 9, 2024
* find and replace naming

* fix tests

* fix missed test

* avoid r and stan name clash and make s3 class more consistent

* fix range of broken tests from renaming

* spell check

* spell check

* catch vignettes needing a rename

* vignette titles

* catch spelling mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants